Skip to content

Measure composer clearance beside the inline Ask section (C61) - #491

Merged
BunsDev merged 5 commits into
cr-v050from
cr-v050-followups
Nov 4, 2026
Merged

BunsDev merged 5 commits into
cr-v050from
cr-v050-followups

Conversation

@BunsDev

@BunsDev BunsDev commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Stacked on #490, targeting cr-v050. Draft: like #490, this waits for Val and shouldn't be enqueued.

Closes the CR-8 matrix's agent follow-ups that #490 left open.

Evidence, all synthetic

  • Mutations: the test went red at both sizes under an overlay on the pane's bottom 200 px and under a panel that takes the pane's height, then passed once restored.
  • One full pass on 7e45440: build and unit exit 0; desktop E2E 497 passed, 7 skipped, 0 failed; site E2E 7 passed. The commits here differ from that SHA only in docs/, after re-stacking on Add a Code Review setting, with accessibility, budget and regression gates #490's results commit.

Hosted CI is running on this PR; it had no result when this was written.

Not established

No live provider, live GitHub read, VoiceOver or reference comparison. Clearance was measured with the synthetic claude and gh, in the test's window sizes.

🤖 Generated with Claude Code

BunsDev and others added 2 commits November 2, 2026 20:18
…ection (C61)

CR-6 built Ask inline rather than as the floating composer C61 was planned
for, so clearance was never re-measured. The new test checks Ask and the last
activity item at 900x600 and 1440x900, with the review panel shut and open.
It fails under an overlay and under a panel that takes the pane's height. The
layout needed no change.

Also bring the CR-8 matrix up to date: #477 already closed C22 and D6, and
authenticated GET-only read to Val's session.

Refs #319, #323, #327.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@vercel

vercel Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
modex Ready Ready Preview Nov 4, 2026 1:35am UTC

Request Review

BunsDev and others added 3 commits November 4, 2026 00:01
* Add worktree retire for unmerged work the owner gives up

prune keeps unmerged work forever because it has no merge proof. retire replaces
that proof with a verified snapshot: dirty tracked and untracked files become a
commit on the tip (built in a temporary index), unknown ignored data becomes a
0600 ignored.tar, and both go through the existing bundle/restore/fsck archive.
Open PRs, active processes, Git operations, locks, hidden index entries and a
moved tip still preserve the work. Removal stays non-forced and the branch is
deleted by expected SHA.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs(worktrees): record pushed retirement repair candidate

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Review of #490 found the C76 contrast check sampled only the first match of
each selector. It now measures every match and the whole tree and diff
regions, which found Refresh files, Retry and Cancel context at 1.72:1 to
2.29:1 in all three themes, because they took the browser's button colours.

Also drop the C61 test's assertion that the window reaches the requested
height. Hosted runners cap it at their screen (677 px), which failed #491.

Refs #319, #327.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@BunsDev
BunsDev merged commit 4077d98 into cr-v050 Nov 4, 2026
5 checks passed
@BunsDev
BunsDev deleted the cr-v050-followups branch November 4, 2026 01:35

This branch was successfully deployed

1 active deployment
Preview — 4077d983 Deployed Nov 4, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant