Skip to content

Ads: the fallback is the card's size, with no empty room above it - #424

Merged
TripleU613 merged 1 commit into
mainfrom
ads-fallback-sprite
Nov 22, 2026
Merged

TripleU613 merged 1 commit into
mainfrom
ads-fallback-sprite

Conversation

@TripleU613

Copy link
Copy Markdown
Owner

The fallback's hidden icon holder (an svg, which ignores hidden) held 150px of empty room above the card. Spec in spec/system/ads_spec.rb.

🤖 Generated with Claude Code

https://claude.ai/code/session_01BUGDaR7qv2d8CuVp7UGSTs

The icons' holder in the fallback's root was hidden with the hidden
attribute, which does nothing on an svg, so it held 300x150 of empty
room above the card.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BUGDaR7qv2d8CuVp7UGSTs
@TripleU613
TripleU613 merged commit 2b9b9d6 into main Nov 22, 2026
@TripleU613
TripleU613 deleted the ads-fallback-sprite branch November 22, 2026 04:51
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 22, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-22T04:53:03.082346Z f3dc3e7 PR opened
🔒 Security Review ✅ Completed 2026-11-22T04:54:34.605349Z f3dc3e7 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant