Skip to content

Moderator-note notification spec: click through Playwright's locator - #422

Merged
TripleU613 merged 1 commit into
mainfrom
fix/mod-note-notification-click
Nov 21, 2026
Merged

TripleU613 merged 1 commit into
mainfrom
fix/mod-note-notification-click

Conversation

@TripleU613

Copy link
Copy Markdown
Owner

Summary

moderator_messages_spec.rb:666 still fails now and then on main after #418 ("Element is not attached to the DOM", on the click). The user menu's list re-renders after it opens, and a Capybara element found just before the click can be detached by the time Playwright clicks it. Clicking through Playwright's locator looks the link up again on each try. Same assertions.

Affected module(s)

  • Moderator tools

Test plan

CI system_tests.

🤖 Generated with Claude Code

The user menu's list re-renders after it opens (the notifications are
marked seen), and a Capybara element found just before the click could
still be detached by the time Playwright clicked it, failing main's system
tests now and then. Playwright's locator looks the link up again on each
try.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-20T20:37:29.797762Z a95597f PR opened
🔒 Security Review ✅ Completed 2026-11-20T20:37:44.805212Z a95597f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@TripleU613
TripleU613 merged commit 1cc401b into main Nov 21, 2026
13 checks passed
@TripleU613
TripleU613 deleted the fix/mod-note-notification-click branch November 21, 2026 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant