Repository navigation
Moderator-note notification spec: click through Playwright's locator - #422
Merged
Merged
Conversation
The user menu's list re-renders after it opens (the notifications are marked seen), and a Capybara element found just before the click could still be detached by the time Playwright clicked it, failing main's system tests now and then. Playwright's locator looks the link up again on each try. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
moderator_messages_spec.rb:666still fails now and then on main after #418 ("Element is not attached to the DOM", on the click). The user menu's list re-renders after it opens, and a Capybara element found just before the click can be detached by the time Playwright clicks it. Clicking through Playwright's locator looks the link up again on each try. Same assertions.Affected module(s)
Test plan
CI system_tests.
🤖 Generated with Claude Code