Repository navigation
Whispers: a client's whisper flag counts only while whispers are on - #416
Merged
Merged
Conversation
Follow-up to #386. With mod_whisper_enabled or jtech_enabled off, a member could still send mod_whisper=true on a post that answers no whisper. Creation ignored it and the post came out public, but its copy in the approval queue kept the flag, so it was hidden from non-staff reviewers and kept out of the reports chat. The queue marker now follows the same rule as creation: the client's flag needs the switch on; answering an existing whisper still marks the post whatever the switch says. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H3rUWsMdwFCAp9g5VhRD7d
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #386 (Codex security review of af08825). With
mod_whisper_enabledorjtech_enabledoff, a member could still sendmod_whisper=trueon a post that answers no whisper.prepare_new_post!ignored it and created a public post, but the approval-queue marker kept the flag in the queued payload, so the queued post was hidden from non-staff reviewers (ReviewableClassWhisperPatch) and kept out of Disteleplus reports (private_reviewable?). The marker now follows creation's rule: the client's flag needsWhisper.enabled?, and is dropped otherwise. Posts answering an existing whisper are still marked whatever the switch says.Affected module(s)
Test plan
New example in
whisper_leak_matrix_spec.rb, "the approval queue": with whispers off, a forged flag leaves nomod_whisperin the payload, the queued post is visible to a category reviewer, isn't private for reports, and is public once approved; a reply to an existing whisper is still private. On the old code the payload keeps the flag and the first expectation fails.Checklist
🤖 Generated with Claude Code
https://claude.ai/code/session_01H3rUWsMdwFCAp9g5VhRD7d