Skip to content

Whispers: a client's whisper flag counts only while whispers are on - #416

Merged
TripleU613 merged 3 commits into
mainfrom
fix/whisper-flag-needs-switch
Nov 21, 2026
Merged

TripleU613 merged 3 commits into
mainfrom
fix/whisper-flag-needs-switch

Conversation

@TripleU613

Copy link
Copy Markdown
Owner

Summary

Follow-up to #386 (Codex security review of af08825). With mod_whisper_enabled or jtech_enabled off, a member could still send mod_whisper=true on a post that answers no whisper. prepare_new_post! ignored it and created a public post, but the approval-queue marker kept the flag in the queued payload, so the queued post was hidden from non-staff reviewers (ReviewableClassWhisperPatch) and kept out of Disteleplus reports (private_reviewable?). The marker now follows creation's rule: the client's flag needs Whisper.enabled?, and is dropped otherwise. Posts answering an existing whisper are still marked whatever the switch says.

Affected module(s)

  • Moderator tools

Test plan

New example in whisper_leak_matrix_spec.rb, "the approval queue": with whispers off, a forged flag leaves no mod_whisper in the payload, the queued post is visible to a category reviewer, isn't private for reports, and is public once approved; a reply to an existing whisper is still private. On the old code the payload keeps the flag and the first expectation fails.

Checklist

  • New / changed behavior has a spec (a bug fix has one that fails without it)
  • Follows the repository rules: hidden stays hidden

🤖 Generated with Claude Code

https://claude.ai/code/session_01H3rUWsMdwFCAp9g5VhRD7d

Follow-up to #386. With mod_whisper_enabled or jtech_enabled off, a member
could still send mod_whisper=true on a post that answers no whisper. Creation
ignored it and the post came out public, but its copy in the approval queue
kept the flag, so it was hidden from non-staff reviewers and kept out of the
reports chat. The queue marker now follows the same rule as creation: the
client's flag needs the switch on; answering an existing whisper still marks
the post whatever the switch says.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01H3rUWsMdwFCAp9g5VhRD7d
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-21T23:56:30.168276Z 0b331fa New commits
🔒 Security Review ✅ Completed 2026-11-21T23:57:32.918192Z 0b331fa New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@TripleU613
TripleU613 merged commit 0fed7d6 into main Nov 21, 2026
10 checks passed
@TripleU613
TripleU613 deleted the fix/whisper-flag-needs-switch branch November 21, 2026 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant