Skip to content

Upstream Android cross-build patches to Node.js core #5

Description

@Towartz

Several patches in .github/workflows/node-android.yml step "3b" work around Android-specific issues in Node.js/V8 that should eventually be upstreamed:

  1. stack_trace_posix.cc — backtrace() stubs for Android API < 33 (PR to gate on __ANDROID_API__ instead?)
  2. trap-handler.h — Android cross-build shouldn't define V8_TRAP_HANDLER_SUPPORTED=true for simulator builds (v26.x already has an #error guard for Android but the chain still fires for the simulator case)
  3. zlib/cpu_features.c — NDK cpufeatures library not available in gyp build; use getauxval(AT_HWCAP) like the Linux path already does
  4. uv/uv.gyp — bare include_dirs vs include_dirs+ causes NDK include path loss
  5. uv_fs_copyfile — FICLONE ioctl not supported on Android filesystems

Each patch is documented inline with the relevant Node.js issue numbers.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions