Repository navigation
chore: require Node.js >=22 - #54
Merged
Merged
Conversation
better-sqlite3 prebuilt binaries are published only for Node >=22, and Node 20 is EOL. Co-authored-by: Raul Jäger <raul@thoughtproof.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Declares Node.js
>=22for pot-cli0.8.12(unreleased). A lockfile-less install on Node 20 resolvesbetter-sqlite3@^12.8.0to12.11.1, whose prebuilt binaries start at Node 22, so Node 20 falls back tonode-gypand fails without a toolchain. Node 20 is EOL.package.jsonsets"engines": { "node": ">=22" }.@pot-sdk2/bridgestays at1.2.0. Thebetter-sqlite3range stays^12.8.0.package-lock.jsonroot entry updated withnpm install --package-lock-onlyon Node 22.## [0.8.12] - Unreleasedheading..github/workflows/package-smoke.ymlalready runs tests on Node 22. It is the only workflow.No version bump, publish, or tag.
Test plan
npm ci,npm run build,npm run test:package(2/2),npm run test:plan(337/337),npm run test:rv(20/20),npm run check:boundariesnpm installofpot-cli-0.8.12.tgzemitsEBADENGINEforpot-cli@0.8.12(required: { node: '>=22' },current: { node: 'v20.20.2', npm: '10.8.2' }). Warning only; install exit code 0.