Skip to content

fix(builder): give the Boat card its logo and a key link, open Settings as its popup, and drop the Engine card - #251

Merged
aitianshi merged 10 commits into
mainfrom
fix/boat-sandbox-logo
Nov 20, 2026
Merged

aitianshi merged 10 commits into
mainfrom
fix/boat-sandbox-logo

Conversation

@aitianshi

@aitianshi aitianshi commented Nov 20, 2026 •

Copy link
Copy Markdown
Collaborator

Closes #250

What

The Where step's Boat card gets Boat's mark (light or dark by theme) and loses its two description lines, which the Isolation line and Limits' concurrency already say. Without a Boat key, Sandboxes can now be chosen: the Boat card is greyed and its one live control, Add API Key, opens the Settings popup on Boat's key form. Every Settings link in the builder now opens the Settings popup (window.nulliusOpenSettings, shared with the popup's own link handling) instead of leaving for the page, and closing the popup, however it was opened, reloads the builder from its draft on the same step. A Where problem is said once: the step no longer draws its own copy of "cannot run in a Boat VM", and a compile error can be marked shown (the missing Boat key, which the card already says) so the step's error line leaves it to Review. The machines sit 20px below the Hosts/Sandboxes switch. Settings → Sandbox drops its Engine card, its probe (sandbox.docker_state, _other) and #243's second-engine row with it: this machine's Docker or Podman is in the Hosts table.

Touches

backend · routes · templates and static · docs and site

Before and after

Run builder, Where step, no Boat key:

Before After
Where step on main: Sandboxes greyed and not selectable Where step on this branch: Sandboxes chosen, a greyed Boat card with its logo and Add API Key

Settings → Sandbox:

Before After
Settings Sandbox on main: Engine card and Boat card Settings Sandbox on this branch: the Boat card alone

Verified

  • Backend suite (3098 tests) and route suite (690 tests) pass after merging main.
  • New and changed tests: the Boat card's marks and its Add API Key link (test_builder_where.py), a non-key Boat problem staying a plain line with Sandboxes disabled, shown set only when no key is saved (test_standard_boat.py), the Sandbox section without the Engine card and its route returning only Boat's state (test_settings_page.py).
  • Headless Chromium, light and dark, 1280 and 390 px: the card's mark per theme, no sideways scroll, no page errors; Add API Key opens the popup with Boat's form open and its field focused; closing the popup, opened from the link or from the rail, lands back on Where with the recipe kept; Settings → Sandbox shows only Boat.
  • Not verified: a real key added or removed, since a fake key would reach Boat's API. The builder reads the key state from the server on each load.

Risk

  • The builder reloads every time the Settings popup closes, even without a change; the draft restores the recipe and step, but a ?run= or ?saved= notice is not shown again.
  • fix(standard): use podman when docker is installed but does not answer #243's note naming a second installed engine leaves Settings with the Engine card; which engine runs is unchanged, and Hosts still shows it.
  • Undone by reverting the squash commit.

… key to Settings

The Where step's Boat card had no mark, unlike Settings. Without a key, the card now offers a button straight to Settings > Sandbox; other reasons Boat cannot run stay a plain line.
…oat card's descriptions, and name its link Add API Key
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

1 similar comment
@github-actions

Copy link
Copy Markdown

🟡 PR judge · 8 of 8 yes · #251 ↔ #250

Merge risk 🔴 MAJOR the judge's reading of the diff; app/nullius/standard/recipe.py is in the path of every run
Priority 🔴 EXTREME the deepest path is app/nullius/standard/recipe.py
Question Verdict
Changes do what the issue asks · 8 of 8 criteria ✅ yes
Issue and pull request describe the same change ✅ yes
Description matches the diff, no more, no less ✅ yes
Diff stays in scope ✅ yes
Tests cover the change, or Verified says how ✅ yes
Docs follow the change ✅ yes
Risk named in the description ✅ yes
Before and after shown · 4 images · the diff touches what is visible ✅ yes
Acceptance criteria, 8 of 8 met
# Criterion Verdict
1 The Where step's Boat card shows Boat's mark, the light or dark one by theme ✅ met
2 Without a Boat key, Sandboxes can be chosen; the card is greyed and Add API Key is its only control ✅ met
3 Add API Key opens the Settings popup with Boat's key form open and focused ✅ met
4 The builder's Settings links open the Settings popup, not the page ✅ met
5 Closing Settings, however it was opened, reloads the builder on the same step with the same recipe ✅ met
6 A problem on the Where step is shown once; the missing key is not repeated beside the card, and Review still lists it ✅ met
7 The Boat card has no description lines ✅ met
8 Settings → Sandbox has no Engine card; its probe and docker_state are removed with it ✅ met
Checks the script runs itself, 4 of 4 pass
No machine attribution trailer in the commits or the description ✓
New code under app/, docs/, .github/ or .claude/ ✓
No Flask import under the backend package ✓
No key-shaped string in the diff ✓

@aitianshi
aitianshi merged commit e80f503 into main Nov 20, 2026
2 checks passed
@aitianshi
aitianshi deleted the fix/boat-sandbox-logo branch November 20, 2026 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Run builder: the Boat card lacks its logo and a way to add its key, and Settings links leave the builder

1 participant