Repository navigation
docs(cli): name the probe and the per-call cap on the first-run surfaces - #1212
Conversation
…ces (#1201) #1166/#1184 added `--max-calls` / `--max-usd`, and docs/start.md documents them, but the lines a new user or host agent follows did not: the shared host skill, the plugin-quickstart habits, the budget paragraph in docs/plugins.md, and the `next:` line `algorithms run` / `demo --algorithm` print. A first real run is started from those lines, so the preflight and the cap belong there -- at the plan's own `agent_calls_upper_bound` for `algorithms run`, and as `<N>` in the demo footer, which runs before a spec exists. `--out spec.json` joins the demo footer so the `plan` / `evolve` steps it adds have a path to name; the `agentdescent.<algo>.spec.json` claim from #1145 stays gone. The two rendered plugin copies were regenerated with render_claude_plugin / render_dsh_plugin, so the drift tests keep them in step instead of a hand edit. Fixes #1201.
|
State change: draft -> ready for review. This PR was opened ready for review. It was converted to draft with no commit attached and no owner for the change; the head is the same commit it was opened at, CI is green on it, and nothing in the diff changed. Restoring the opened state so the review lane can see it. |
|
Advisory Verifier report; Verdict: PASS (advisory) Ran (fresh clone at
Not run:
SummaryCloses #1201. Five docs/CLI text surfaces, the two re-rendered skill copies, four test files and one changelog fragment: the shared host skill now names the per-call cap ( The evidence is honest: the new file alone fails 7/7 at base, one row per surface, the four modified test files also fail there (14 rows), and at the tip the seven rows, the 80-row focused set and the rendered-copy drift check are green. The names the skill tells a host to pass are real on both MCP tools ( BlockingNone. Non-blocking
Risk / mergeT3 by path ( No UI surface: CLI No merge action from QA: this report is advisory, the merge gate is the repo's review decision on the head sha, and the merge itself is executed by the repo's merge process. |
|
Review (Birfy) Tip SHA: c664993
|
Closes #1201.
Base:
1aa816e0e155c2f59db1686e404a7ebae739d94bTip SHA:
c6649930fd9bc39b3f0f8af09c595e755e44a79dWhat changed
#1166/#1184shipped a per-call cap (evolve --max-calls/--max-usd, MCPplan/startfieldsmax_calls/max_usd).docs/start.mddocuments it, but the surfaces a first-run user or host agent actually follows did not mention it:agentdescent/integrations/SKILL.md(the shared host skill, installed identically on claude-code, dsh, codex, opencode and grok-bot): the plan step now tells the host to give a first real run a ceiling that holds before each call —max_calls, andmax_usdwithusd_per_call, on MCPplan/start;--max-calls/--max-usdon the CLI — and keeps--budgetdescribed as the between-round bound that can overshoot.--probestays the first-model preflight.docs/plugin-quickstart.md"Two habits worth keeping" and the budget paragraph ofdocs/plugins.md: the same cap, with the overshoot warning kept and a pointer todocs/start.md#real-model.algorithms run'snext:is nowagentdescent plan <spec> --probe, then agentdescent evolve <spec> --max-calls N, whereNis the plan's ownestimate.agent_calls_upper_bound(a placeholder<N>only when the plan reports no positive bound). It stays one string for both the text line and--json.next, and it does not start a run.demo --algorithm's footer is now four steps —algorithms run … --out spec.json,plan spec.json --probe,evolve spec.json --max-calls <N>,doctor.--out spec.jsongives the two consuming steps a real path; the cap is<N>because the demo has no estimate. One list still feeds both the footer and--json.next.integrations/claude-code/skills/agentdescent/SKILL.mdandintegrations/dsh-agentdescent/lib/index.js) were regenerated withrender_claude_plugin/render_dsh_plugin, not hand-edited;tests/test_integrations.pystill owns the drift check, so the new test file carries no duplicate equality row.tests/test_demo.py's old"--out spec.json" not in outguard becomes a positive assertion: the demo does not claim a spec exists, and the comment now says so — the#1145rule thatdemomust not point atagentdescent.<algo>.spec.jsonis kept verbatim.Verification at the tip
Tip SHA:
c6649930fd9bc39b3f0f8af09c595e755e44a79dRan:
pytest -q -o addopts='' tests/test_first_run_caps.py→7 passedpytest -q -o addopts='' test_first_run_caps + test_cli_algorithms_run + test_demo + test_plan_text_output→80 passedpytest -q -o addopts='' tests/test_integrations.py(both rendered copies drift-checked) →105 passed, 2 skipped1aa816e0→7 failedpython -m tools.gen_api_docs --check→docs/api.md is up to datepython -m tools.changelog_fragments check→15 changelog fragment(s) OKNot run:
pytest -q— the CI matrix is the line for this docs/CLI-text changemkdocs build --strict— the social plugin fetchesfonts.google.comon this offline host; a local copy with social cards off builds rc 0 (25.60s)Red first
At the base
1aa816e0, clean worktree, onlytests/test_first_run_caps.pyadded:exactly the seven rows:
test_shared_host_skill_names_the_per_call_cap,test_plugin_quickstart_habits_name_the_per_call_cap,test_plugins_budget_paragraph_names_the_per_call_cap,test_algorithms_run_next_names_the_probe_then_the_cap[gepa|archive_selection],test_demo_algorithm_footer_names_the_probe_then_the_cap[gepa|archive_selection].Green at the tip
Full suite and docs at the tip
Full suite, same 8-chunk split at
c6649930-> 7606 tests, 21 failed, 10 errors, 56 skipped; the failing-id set is identical to base1aa816e0(commempty both ways), so 0 new red.mkdocs build --strict-> rc 0 in 21.29 s with thesocialplugin excluded; the unmodified config hangs on this host atmaterial/socialpost_page, which is a host limitation, and CI'sbuildjob runs the unmodified config.Not run: no real model call -- every changed line is a printed string, a doc paragraph, or a test that reads them.Scope
Five docs/CLI text surfaces, the two re-rendered plugin copies, one updated demo guard, the
algorithms runnext-step string, the new test file and onechangelog.d/fragment. No new flag, no behaviour change:plan's own defaultnext:(cli.py:2489) is deliberately untouched and wants its own card. T2 by path and size.