Repository navigation
Conversation
The demotion half of the controller had no event trigger: a label set by a non-maintainer, or an edit after the approval, was only read at the next cron tick. Measured on this repository: the schedule skipped 14 h 16 min once (19 Nov 18:10 -> 20 Nov 08:26 UTC), so an approval someone had just voided stayed usable for that window. Adding issues labeled/unlabeled/edited cannot loop: the controller never labels an issue itself, and the run its own removal triggers plans nothing.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1209.
What changed
The controller's demotion half — removing
agent-ready/agent-workingwhen a non-maintainer labels an issue or edits it after the approval — had no event trigger, so it was read only at the next cron tick..github/workflows/controller.ymladdsissues: types: [labeled, unlabeled, edited]next to the existingpull_request(opened/ready_for_review/reopened),scheduleandworkflow_dispatch. The comment aboveon:states why, with the measured gap.AGENTS.md(Controller section) names the new events beside thepull_requestones, so the documented trigger set matches the file.tests/test_process_controller.py:test_workflow_shapenow pins all four trigger names and eachtypeslist, with the measurement in the failure message, so deleting any one goes red.changelog.d/1209-controller-issue-events.mdrecords the change.Loop safety: the controller never labels an issue itself, and a run with an empty op list does not go live, so the run its own removal triggers plans nothing.
Unchanged: top-level
permissions: {};planstays read-only (contents: read,issues: read,pull-requests: read);applystays exactlycontents: read,issues: write,pull-requests: write; both jobs pinref: ${{ github.event.repository.default_branch }}; nopull_request_target, no secrets. The fork guard is untouched, so apull_requestrun from a fork head is still skipped in both jobs.Why it matters
controllerworkflow (389438252)scheduleruns, read from the Actions API on 2026-11-21 (Date: Sat, 21 Nov 2026 17:29:45 GMT):A voided approval stayed usable for that whole window. This change reads the voiding event in the same minute.
Verification at the tip
Red at
1aa816e0(livemain) with only this tip'stests/test_process_controller.pycopied in:At this tip:
Full
pytest -qhere: not run.tests/test_docs_links.py:11imports Python-Markdown(
markdown_itis installed, Python-Markdown is not), so collection stops before the suite;no docker in this box either. CI is the line for the full matrix.
Not run:
mkdocs build --strict-- no page or nav change (AGENTS.mdis repository-root, outside the docs tree).Tip SHA: 334e4d6