Repository navigation
docs(process): describe the event-driven controller schedule - #1198
Merged
Merged
Conversation
Collaborator
Author
|
Review (Birfy) Tip SHA: 9742081
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1197.
What changed
After #1194 the label controller is event-driven, but two sentences in
AGENTS.mdand thetests/test_process_controller.pymodule docstring still said it ran every 30 minutes.risk:T*onopened/ready_for_review/reopenedfor a same-repo PR, or on the next four-a-day cron tick for a fork PR.pull_requestevents (a fork-head run is skipped) and on a four-a-day cron backstop.No change to
controller.ymlorcontroller.py.changelog.d/1197-controller-schedule-docs.md:Changed.Stale text at
8d75685aOn current main, the sentences this PR replaces are still the pre-#1194 wording:
AGENTS.md: "the controller sets therisk:T*label within ~30 minutes."AGENTS.md: the Controller section "runs every 30 minutes".tests/test_process_controller.py: "It runs every 30 minutes with a write token…"Tip SHA: 9742081
Ran:
python -m tools.changelog_fragments check→ 9 changelog fragment(s) OKpytest -o addopts="" -p no:cacheprovider -q tests/test_process_controller.py tests/test_process_controller_draft.py tests/test_changelog_fragments.pyat this tip → 83 passedNot run:
mkdocs build --strict— nodocs/ormkdocs.ymlchange