Skip to content

[test] canvas: correct nightly lock fixtures and generation receipts - #431

Merged
wangtiance merged 1 commit into
ThinkFlowLab:mainfrom
wangtiance:codex/nightly-followup
Nov 22, 2026
Merged

wangtiance merged 1 commit into
ThinkFlowLab:mainfrom
wangtiance:codex/nightly-followup

Conversation

@wangtiance

Copy link
Copy Markdown
Collaborator

Summary

The latest Nightly run failed in three browser scripts: https://github.com/ThinkFlowLab/OpenDirector/actions/runs/44956890634/job/137006885406

  • [test] providers: diagnose video capability generation failures #423 incorrectly required applied for the second generation.submit response. Asynchronous generation correctly returns accepted. Correct that assertion while retaining diagnostics and the original 20-second completion wait.
  • [feat] canvas: group toolbar, group colors, and no more node locking #415 releases imported locks on first project open. Both subject scripts imported a locked node and later expected it to remain locked. Create unlocked fixtures, wait for the first-open policy, then apply a current API lock using the canvas item's authoritative revision. Check the applied receipt, persisted lock and rendered lock before exercising the existing editing/media restrictions.

本次修正三个已确认的测试失败:异步生成回执应为 accepted;主体测试改为在首次开页完成后通过正式 API 加锁,并检查版本、回执、持久化状态和界面锁定。保留现有编辑、上传、重开及生成结果断言,不修改产品锁规则或生成逻辑。

Scope and remaining uncertainty / 已解决与未解决

The subject editing failure was reproduced locally at the same assertion as CI. Persisted state showed the imported lock had been released; this matches #415's explicit first-open behavior. Both subject workflows pass with a new API lock. The corrected generation workflow passes in en-US and zh-CN with saved job inputs, technical checks and readable MP4 bytes verified.

本地已复现并修正主体测试前置条件冲突;三个修改后的浏览器用例均通过。最初运行 44836587419 的 20 秒生成超时本次没有复现,其历史根因仍未确定。本 PR 不声称修复那个超时,也不声称整个 Nightly 已通过。Windows 本地结果不替代 Linux CI;生成使用隔离模型替身,未验证真实模型。

Linked issue

Labels

  • type:ci, area:ci, area:canvas, area:provider

Test plan

Local, on main baseline 9c19142 with the changes, isolated creation_server.py --assistant-fixture and Vite, Playwright 1.58.2 / Chromium headless shell 145.0.7632.6, Windows:

  • PASS: node tests/browser/subject_node_editing.mjs (including locked controls and reopening)
  • PASS: node tests/browser/subject_node_media.mjs (including locked upload controls, playback, preserved primary media and reload)
  • PASS: node tests/browser/video_capability_roles.mjs (en-US and zh-CN; one successful job each, preserved input/reference, technical check and readable MP4)
  • PASS: node --check for all three changed scripts; Prettier formatting; npm run check:browser-manifest; git diff --check
  • Initial cold navigation timed out locally; the successful browser run followed Vite warmup. No timeout thresholds were changed.
  • Pre-commit skipped for this commit per explicit user authorization after Windows permission failures. No hook configuration permanently changed.
  • Left to CI: release checks and the full Linux Nightly lane. The original generation timeout remains unexplained.

Evidence that it works

  • N/A for screenshots: test fixture and assertion corrections only; no application/UI changes. Browser assertions check real persisted objects and substitute media bytes.

Provider verification

  • No real-provider calls. Generation and media use isolated test fixtures; capability discovery uses a local HTTP fixture.

Bilingual UI

  • No user-facing copy changed. The video workflow ran successfully in both en-US and zh-CN; existing subject workflows use zh-CN.

## summary

- Establish version-checked API locks after the first-open lock release
  before asserting subject editing and media restrictions.
- Require accepted for asynchronous generation submission receipts.

## validation

Subject editing, subject media and bilingual video capability browser
workflows passed with isolated fixtures and Chromium 145. Syntax,
browser manifest and diff checks passed. No real models were called.
Pre-commit is skipped per user authorization.
@wangtiance wangtiance added area:canvas Canvas, nodes and direct manipulation area:ci Continuous integration and checks area:provider Model providers and generation protocols type:ci Build, test and release automation labels Nov 22, 2026
@wangtiance
wangtiance merged commit fc2ff9f into ThinkFlowLab:main Nov 22, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:canvas Canvas, nodes and direct manipulation area:ci Continuous integration and checks area:provider Model providers and generation protocols type:ci Build, test and release automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant