Repository navigation
[test] canvas: correct nightly lock fixtures and generation receipts - #431
Merged
Merged
Conversation
## summary - Establish version-checked API locks after the first-open lock release before asserting subject editing and media restrictions. - Require accepted for asynchronous generation submission receipts. ## validation Subject editing, subject media and bilingual video capability browser workflows passed with isolated fixtures and Chromium 145. Syntax, browser manifest and diff checks passed. No real models were called. Pre-commit is skipped per user authorization.
wangtiance
requested review from
hsliuustc0106 and
princepride
as code owners
November 22, 2026 00:41
github-actions
Bot
requested review from
FayeSpica,
Probiotics5333,
allendyu and
nikiwang-125
November 22, 2026 00:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The latest Nightly run failed in three browser scripts: https://github.com/ThinkFlowLab/OpenDirector/actions/runs/44956890634/job/137006885406
appliedfor the secondgeneration.submitresponse. Asynchronous generation correctly returnsaccepted. Correct that assertion while retaining diagnostics and the original 20-second completion wait.本次修正三个已确认的测试失败:异步生成回执应为
accepted;主体测试改为在首次开页完成后通过正式 API 加锁,并检查版本、回执、持久化状态和界面锁定。保留现有编辑、上传、重开及生成结果断言,不修改产品锁规则或生成逻辑。Scope and remaining uncertainty / 已解决与未解决
The subject editing failure was reproduced locally at the same assertion as CI. Persisted state showed the imported lock had been released; this matches #415's explicit first-open behavior. Both subject workflows pass with a new API lock. The corrected generation workflow passes in en-US and zh-CN with saved job inputs, technical checks and readable MP4 bytes verified.
本地已复现并修正主体测试前置条件冲突;三个修改后的浏览器用例均通过。最初运行 44836587419 的 20 秒生成超时本次没有复现,其历史根因仍未确定。本 PR 不声称修复那个超时,也不声称整个 Nightly 已通过。Windows 本地结果不替代 Linux CI;生成使用隔离模型替身,未验证真实模型。
Linked issue
Labels
type:ci,area:ci,area:canvas,area:providerTest plan
Local, on main baseline 9c19142 with the changes, isolated creation_server.py --assistant-fixture and Vite, Playwright 1.58.2 / Chromium headless shell 145.0.7632.6, Windows:
Evidence that it works
Provider verification
Bilingual UI