Skip to content

Read a running task's status in the window language (#3114) - #3269

Merged
Birfy merged 1 commit into
mainfrom
dev/3114-running-status-zh
Nov 20, 2026
Merged

Birfy merged 1 commit into
mainfrom
dev/3114-running-status-zh

Conversation

@Birfy

@Birfy Birfy commented Nov 20, 2026 •

Copy link
Copy Markdown
Collaborator

Written-by: Dev
Fixes #3268
Part of #3114
Owner: Dev
Reviewer: Reviewer
Docs-not-needed: two dictionary keys, one test and one changelog fragment; no component or structure change.

What changed

Before: a Chinese window drew the host task ids claimed / working bare in the Status column of the Project board's Running tasks table. The draw point (core/src/client/project-board.js:550) already read t(row.status); the dictionary simply had no entry for either id, so t() returned the key.

After: two bare keys in core/src/client/i18n.js, beside running / stalled and the cut-35 meeting keys — claimed: '已认领', working: '进行中', the same words the kanban already uses for those two states (Claimed / In progress). Nothing else changes: no component, no structure, no draw point, and no mapping table. An English window still reads claimed / working (a bare key returns itself with no locale), data-task-id / data-overdue stay the host ids, and an id the client cannot name is still drawn as it came.

Two hand-written product files plus one fragment: core/src/client/i18n.js (+4/-0), core/test/project-board-view.test.js (+25/-0), changelog.d/3114-cut-36-running-status.fixed.md (+1/-0). The client bundle and the five generated patch artifacts were regenerated by npm run build and node scripts/ds-bot-patches.mjs generate, never hand-edited. core/src/host/**, plugins/**, patches/ds-bot/topics.json and the four i18n baselines are untouched.

Verification at the tip

Tip SHA: 3417782a87906df401a9f59e74145959e05ab968 (tree fc2b56dc00924e47114dd7d20a4cbff79d8378fd)

$ cd core && TZ=UTC node --test test/project-board-view.test.js
# tests 40 / pass 40 / fail 0
$ cd core && TZ=UTC node --test test/i18n.test.js test/i18n-missing-entries.test.js test/i18n-template-draws.test.js test/i18n-plugins.test.js test/i18n-plugins-missing-zh.test.js
# tests 41 / pass 41 / fail 0
$ node -e "for (const f of ['i18n-plugins','i18n-template-draws','i18n-missing-entries','i18n-plugins-missing-zh']) console.log(f, require('./core/test/'+f+'.baseline.json').entries.length)"
i18n-plugins 12 / i18n-template-draws 9 / i18n-missing-entries 46 / i18n-plugins-missing-zh 2
$ node core/scripts/build-client.mjs --check          # rc 0
$ node scripts/ds-bot-patches.mjs canonical           # ok   patches/ds-bot/ is what generate writes (generate is a no-op)
$ node scripts/ds-bot-patches.mjs check               # ok pin; ok 10 patches apply cleanly; ok core/ equals ds-bot/ + patches/ds-bot/
$ node .github/scripts/changelog.mjs check             # changelog: 17 fragment(s) are well formed
$ git archive HEAD | tar -x -C <clean dir> && node .github/scripts/check-mojibake.mjs --check
mojibake: ok - 0 occurrences of U+FFFD in 1786 text file(s)
$ ARCH_DOCS_BASE=origin/main node core/scripts/check-arch-docs.mjs
arch-docs: OK (7 changed file(s))
$ git diff --shortstat origin/main...HEAD
7 files changed, 69 insertions(+), 2 deletions(-)

Red first - the clean 4031b9e archive plus only the new test, implementation untouched:

  • cd core && TZ=UTC node --test test/project-board-view.test.js -> # tests 40 / # pass 39 / # fail 1; case 40 stopped at actual ['claimed','working','on-hold'] vs expected ['已认领','进行中','on-hold']. Clean main on the same file is 39/39/0.

At the tip the same command is 40/40/0. The case asserts both windows on one record: English reads claimed / working / on-hold, zh reads 已认领 / 进行中 / on-hold - a third value the host never emits, so the client is proved to look up and not guess. The Status spans are selected by their bt-project-running-status class; the data-* attributes are not part of the copy.

Risk gate over the seven changed paths, objects carrying patch (the shape the PR files API serves): T1 0 30 3 4 - hand-written 30 lines / 3 files, 4 generated paths. The names-only trap was reproduced on the same diff (T0 0 0 7 0). Budget leaves 370 lines / 17 files. The forbidden-surface regex hits 0 (core/src/host/, plugins/, topics.json, the four i18n-*.baseline.json, about.js, capability-settings.js, sidebar.js, project-board.js) and the positive control on the same regex hits 3. git diff --name-only origin/main...HEAD | grep -c 'core/src/client/project-board.js' -> 0, and the draw point still reads t(row.status) once.

Not run (and why): the full TZ=UTC npm run verify. This box has only esbuild in the shared core/node_modules symlink (no @deepseek-ai/* harness packages, and the brief forbids npm ci), so the core suite cannot start here; CI at this tip carries it. Everything runnable here was run at this tip: the affected test file, the five i18n gates, the bundle check, the patch checks, changelog, mojibake, arch-docs and the risk gate.

Checkpoint

{
  "pr": 3269,
  "claim": "Dev",
  "issue": 3268,
  "summary": "The Project board's Running tasks table drew the host task ids claimed / working bare in a Chinese window: the draw point already read t(row.status), but the dictionary had neither id. Two bare keys in core/src/client/i18n.js now read them as 已认领 / 进行中. No component, no structure and no draw point change: project-board.js is byte-identical and data-* attributes stay the host ids. One test (the 40th) covers both windows and an id the client cannot name: red first 40/39/1, after the fix 40/40/0. The bundle and the generated patch artifacts were regenerated, never hand-edited.",
  "files": ["core/src/client/i18n.js", "core/test/project-board-view.test.js", "changelog.d/3114-cut-36-running-status.fixed.md", "core/client.js", "patches/ds-bot/0001-core-fixes.patch", "patches/ds-bot/0008-client-bundle.patch", "patches/ds-bot/files/test/project-board-view.test.js"],
  "checks": { "ran": "project-board-view 40/39/1 red then 40/40/0 green; five i18n gates 41/41/0; baselines 12/9/46/2; npm run build; ds-bot-patches generate/canonical/check; build-client --check; changelog 17; mojibake 1786; arch-docs OK (7); risk gate T1 0 30 3 4", "result": "green", "at": "3417782a87906df401a9f59e74145959e05ab968" },
  "next": "none - ready for review"
}

Docs-not-needed: two dictionary keys, one test and one changelog fragment; no component or structure change.
@Birfy Birfy added the agent-pr Pull request opened by an agent label Nov 20, 2026
@Birfy Birfy self-assigned this Nov 20, 2026
@Birfy

Birfy commented Nov 20, 2026

Copy link
Copy Markdown
Collaborator Author

Written-by: Dev

Measured at tip 3417782a87906df401a9f59e74145959e05ab968:

  • Risk gate over the seven changed paths, objects carrying patch (the shape the PR files API serves): T1 0 30 3 4 — 30 hand-written lines / 3 files / 4 generated. The names-only trap reproduces on the same diff: T0 0 0 7 0.
  • Four i18n baselines, read as entries.length (no --write was run, and none of the four files is in the diff):
    • i18n-plugins 12
    • i18n-template-draws 9
    • i18n-missing-entries 46
    • i18n-plugins-missing-zh 2
  • Tests: core/test/project-board-view.test.js 40/40/0; red first on the clean 4031b9e archive with only the new test was 40/39/1 (actual 'claimed' vs expected '已认领'). Five i18n gates 41/41/0.
  • Generated artifacts: npm run build + ds-bot-patches generate (second pass zero diff) + canonical ok + check three ok lines + build-client --check rc 0; core/node_modules was a symlink, never added.
  • Other gates: changelog.mjs check → 17 fragments; check-mojibake.mjs --check on the archive tree → 1786 text files / 0 U+FFFD (main archive 1785); ARCH_DOCS_BASE=origin/main check-arch-docs.mjs → arch-docs: OK (7 changed file(s)); git diff --shortstat origin/main...HEAD → 7 files changed, 69 insertions(+), 2 deletions(-).
  • Draw point untouched: core/src/client/project-board.js is not in the diff, and the Status span still reads t(row.status) exactly once. patches/ds-bot/topics.json and baselines are not in the diff either.

Not run here: the full TZ=UTC npm run verify — this box has only esbuild in the shared core/node_modules (no @deepseek-ai/* harness packages, and npm ci is out of scope), so the core suite cannot start; CI at this tip carries it.

Not enqueued and not merged — waiting for review.

@Birfy

Birfy commented Nov 20, 2026 •

Copy link
Copy Markdown
Collaborator Author

Spot-check at the tip, before the queue (enqueue node)

Read at 2026-11-20T13:45Z–13:50Z via GitHub REST: /pulls/3269, /pulls/3269/files (objects carrying patch), /commits/3417782a.../check-runs, /branches/main/protection, GraphQL enqueuePullRequest. Tip 3417782a87906df401a9f59e74145959e05ab968, base main 4031b9edc19c5998f5f26f57e7b004b40281f70a (unchanged since dispatch). Own numbers below, from the tree and the diff, not copied from the description.

  1. Shape: 7 files, +69 / −2 — core/src/client/i18n.js +4/−0, core/test/project-board-view.test.js +25/−0, changelog.d/3114-cut-36-running-status.fixed.md +1/−0, core/client.js +4/−0, patches/ds-bot/0001-core-fixes.patch +5/−1, patches/ds-bot/0008-client-bundle.patch +5/−1, patches/ds-bot/files/test/project-board-view.test.js +25/−0. Exact match, nothing extra.
  2. Draw point untouched: project-board.js in the diff → 0; it still reads t(row.status) once.
  3. Dictionary adds only: removed lines in the i18n.js hunk → 0; ^ (claimed|working): ' → 2, byte-for-byte claimed: '已认领' / working: '进行中'.
  4. English unchanged: no capitalised Claimed/Working key added (the two that exist, i18n.js:65 / :939, are pre-existing and outside the diff); the new case's first assertion is the bare English read ['claimed','working','on-hold'] and it passes.
  5. No smuggling: added lines in the whole diff match Groups 0, Star 0, Could not connect: 0, DSH Agent 0, meeting.advance.reason 0, {}s 0, {}m 0.
  6. Baselines untouched: baseline.json in the diff → 0; the four are byte-identical to base, 12 / 9 / 46 / 2.
  7. Generated artifacts: node core/scripts/build-client.mjs --check → rc 0; node scripts/ds-bot-patches.mjs check → ok 10 patches apply cleanly in order, ok core/ equals ds-bot/ + patches/ds-bot/ (its pin line prints skipped pin (no git) — this box has no git binary, so the tree hash cannot be computed here; the two checks that matter are ok); working tree unmodified; patches/ds-bot/files/src/client/i18n.js does not exist.
  8. Changelog: node .github/scripts/changelog.mjs check → 17 fragment(s) well formed (base 16).

Red first → green (cd core && TZ=UTC node --test test/project-board-view.test.js), run here on the clean base archive plus only the new test, implementation at base:

  • base archive + new test → 40 / 39 / 1, case 40 actual ['claimed',…] vs expected ['已认领','进行中','on-hold'].
  • tip tree → 40 / 40 / 0.
  • five i18n gates at the tip → 41 / 41 / 0.

Risk tier computed with the PR-files objects carrying patch: risk-tier: T1; basis: …7 paths all T1 — T1 0 30 3 4 (30 changed lines in 3 files, 4 generated paths not counted). T1 direct path, so this comment comes from the enqueue node rather than review.

Checks at the tip: 19 total, all terminal — 13 success, 4 cancelled, 2 skipped, 0 failure. tests-ok, enqueue-guard, merge-gate, policy-sign all success. The 4 cancelled are agent-audience ×2 and judge ×2 (duplicate copies of the same suites superseded in the run), which is why GraphQL reports mergeStateStatus: UNSTABLE; neither name is a required context — branch protection on main requires only ubuntu-latest · Node 24 · DSH 0.2.0-rc.2 (success) and tests-ok (success). Nothing is failing — UNSTABLE here is the cancelled copies, not a red.

Four checks: PASS not needed (tier T1); no hold, agent-pr present, body has Fixes #3268, not draft, base main; ## Checkpoint block is 1326 chars ≤ 1500, pr 3269 / claim Dev / issue 3268 / summary 580 ≤ 600 / 7 files, one in this diff / checks green at the tip / next 23 chars.

Enqueued at 2026-11-20T13:50:15Z: entry MQE_lQDOVIxL0c8AAAABQrVkUs4ABOPczgQtAlY, position 1, state QUEUED, expectedHeadOid = the tip above. Watching merge_group next.

Merge queue, closed out. merge_group at head gh-readonly-queue/main/pr-3269-4031b9edc…:

  • Enqueue guard — success (run 44747873894)
  • Merge gate — success (run 44747873959)
  • Test — success (run 44747874134; tests-ok, policy-sign, ubuntu-latest · Node 24, package and the five plugin jobs all success — no npm 404 on this one)

Merged at 2026-11-20T13:53:39Z, merge commit 7f95f0cfffb1d0dfb14ba8b58e5ebe19c5c8f388; main head is that same commit, so nothing else landed alongside. #3268 went closed / completed at 13:53:41Z on its own — not closed by hand.

Merged via the queue into main with commit 7f95f0c Nov 20, 2026
14 of 19 checks passed
@Birfy
Birfy deleted the dev/3114-running-status-zh branch November 20, 2026 13:53
@github-actions github-actions Bot removed the agent-pr Pull request opened by an agent label Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

项目看板:在跑任务表的状态列把 claimed / working 按窗口语言显示(Cut 36)

1 participant