Repository navigation
Read a running task's status in the window language (#3114) - #3269
Conversation
Docs-not-needed: two dictionary keys, one test and one changelog fragment; no component or structure change.
|
Written-by: Dev Measured at tip
Not run here: the full Not enqueued and not merged — waiting for review. |
Spot-check at the tip, before the queue (enqueue node)Read at 2026-11-20T13:45Z–13:50Z via GitHub REST:
Red first → green (
Risk tier computed with the PR-files objects carrying Checks at the tip: 19 total, all terminal — 13 success, 4 cancelled, 2 skipped, 0 failure. Four checks: PASS not needed (tier T1); no Enqueued at 2026-11-20T13:50:15Z: entry Merge queue, closed out.
Merged at 2026-11-20T13:53:39Z, merge commit |
Written-by: Dev
Fixes #3268
Part of #3114
Owner: Dev
Reviewer: Reviewer
Docs-not-needed: two dictionary keys, one test and one changelog fragment; no component or structure change.
What changed
Before: a Chinese window drew the host task ids
claimed/workingbare in the Status column of the Project board's Running tasks table. The draw point (core/src/client/project-board.js:550) already readt(row.status); the dictionary simply had no entry for either id, sot()returned the key.After: two bare keys in
core/src/client/i18n.js, besiderunning/stalledand the cut-35 meeting keys —claimed: '已认领',working: '进行中', the same words the kanban already uses for those two states (Claimed/In progress). Nothing else changes: no component, no structure, no draw point, and no mapping table. An English window still readsclaimed/working(a bare key returns itself with no locale),data-task-id/data-overduestay the host ids, and an id the client cannot name is still drawn as it came.Two hand-written product files plus one fragment:
core/src/client/i18n.js(+4/-0),core/test/project-board-view.test.js(+25/-0),changelog.d/3114-cut-36-running-status.fixed.md(+1/-0). The client bundle and the five generated patch artifacts were regenerated bynpm run buildandnode scripts/ds-bot-patches.mjs generate, never hand-edited.core/src/host/**,plugins/**,patches/ds-bot/topics.jsonand the four i18n baselines are untouched.Verification at the tip
Tip SHA:
3417782a87906df401a9f59e74145959e05ab968(treefc2b56dc00924e47114dd7d20a4cbff79d8378fd)Red first - the clean 4031b9e archive plus only the new test, implementation untouched:
cd core && TZ=UTC node --test test/project-board-view.test.js-># tests 40 / # pass 39 / # fail 1; case 40 stopped at actual['claimed','working','on-hold']vs expected['已认领','进行中','on-hold']. Clean main on the same file is 39/39/0.At the tip the same command is 40/40/0. The case asserts both windows on one record: English reads
claimed/working/on-hold, zh reads已认领/进行中/on-hold- a third value the host never emits, so the client is proved to look up and not guess. The Status spans are selected by theirbt-project-running-statusclass; thedata-*attributes are not part of the copy.Risk gate over the seven changed paths, objects carrying
patch(the shape the PR files API serves):T1 0 30 3 4- hand-written 30 lines / 3 files, 4 generated paths. The names-only trap was reproduced on the same diff (T0 0 0 7 0). Budget leaves 370 lines / 17 files. The forbidden-surface regex hits 0 (core/src/host/,plugins/,topics.json, the fouri18n-*.baseline.json,about.js,capability-settings.js,sidebar.js,project-board.js) and the positive control on the same regex hits 3.git diff --name-only origin/main...HEAD | grep -c 'core/src/client/project-board.js'-> 0, and the draw point still readst(row.status)once.Not run (and why): the full
TZ=UTC npm run verify. This box has onlyesbuildin the sharedcore/node_modulessymlink (no@deepseek-ai/*harness packages, and the brief forbidsnpm ci), so the core suite cannot start here; CI at this tip carries it. Everything runnable here was run at this tip: the affected test file, the five i18n gates, the bundle check, the patch checks, changelog, mojibake, arch-docs and the risk gate.Checkpoint
{ "pr": 3269, "claim": "Dev", "issue": 3268, "summary": "The Project board's Running tasks table drew the host task ids claimed / working bare in a Chinese window: the draw point already read t(row.status), but the dictionary had neither id. Two bare keys in core/src/client/i18n.js now read them as 已认领 / 进行中. No component, no structure and no draw point change: project-board.js is byte-identical and data-* attributes stay the host ids. One test (the 40th) covers both windows and an id the client cannot name: red first 40/39/1, after the fix 40/40/0. The bundle and the generated patch artifacts were regenerated, never hand-edited.", "files": ["core/src/client/i18n.js", "core/test/project-board-view.test.js", "changelog.d/3114-cut-36-running-status.fixed.md", "core/client.js", "patches/ds-bot/0001-core-fixes.patch", "patches/ds-bot/0008-client-bundle.patch", "patches/ds-bot/files/test/project-board-view.test.js"], "checks": { "ran": "project-board-view 40/39/1 red then 40/40/0 green; five i18n gates 41/41/0; baselines 12/9/46/2; npm run build; ds-bot-patches generate/canonical/check; build-client --check; changelog 17; mojibake 1786; arch-docs OK (7); risk gate T1 0 30 3 4", "result": "green", "at": "3417782a87906df401a9f59e74145959e05ab968" }, "next": "none - ready for review" }