Repository navigation
Read the missing decision file in the window's language (#3114) - #3264
Conversation
Docs-not-needed: one literal swapped for t(); the dictionary entry already exists.
|
Written-by: Dev 三数(同一条命令,
档位( 未跑全量 按派活不自行入队,停在这里等复核。 |
Enqueue evidence — tip
|
Written-by: Dev
Fixes #3263
Part of #3114
Owner: Dev
Reviewer: Reviewer
Docs-not-needed: one literal swapped for t(); the dictionary entry already exists.
What changed
Before: in a zh window a decided meeting whose decision file is gone drew the bare English literal
decision file gonein the Project board's record section. After: the same cell drawst('decision file gone'), so a zh window reads 「决策文件已不在」, while an English window is byte for byte unchanged. The dictionary entry already existed (core/src/client/i18n.js:1602, written by #1767), soi18n.jshas 0 changed lines here.Only the third argument of the one
bt-project-missingspan changed (core/src/client/project-board.js:651, +1/−1). The row still readsdata-status="decided"; the question, the@speaker,bt-project-missing's CSS and prop,meeting.status(:663) andmeeting.advance.reason(:661) are untouched;core/src/host/**is not touched — the host still answerspath: ''and the row still disappears only when the meeting does. A non-empty path is still drawn as it came, never translated.Verification at the tip
Tip SHA:
59e307580c973d515e891b2dfbe4529511273a6f(tree695ba8aa7df2b7c8a660fad26a41a40c39eec246)Ran at this tip:
Every command above was run on a tree byte-equal to the tip; the red-first run is recorded in the PR comment and in
red.txt/red-full.log.Red first — only the test added,
core/src/client/project-board.jsat the merge base:cd core && TZ=UTC node --test test/project-board-view.test.js→# tests 38 / # pass 37 / # fail 1; case 38 expected决策文件已不在, actualdecision file gone. Clean main on the same file is 37/37/0.At the tip:
# tests 38 / # pass 38 / # fail 0.test/i18n.test.js test/i18n-missing-entries.test.js test/i18n-template-draws.test.js test/i18n-plugins.test.js test/i18n-plugins-missing-zh.test.js) →41 / 41 / 0; the three baselines12 / 9 / 46ok.cd core && npm run buildregeneratedcore/client.js;node scripts/ds-bot-patches.mjs generatetwice (idempotent, zero diff the second time);canonical→ok patches/ds-bot/ is what generate writes (generate is a no-op);check→ threeoklines;node core/scripts/build-client.mjs --check→ rc 0;git status --porcelainempty.node .github/scripts/changelog.mjs check→ 15 well-formed fragments;node .github/scripts/check-mojibake.mjs --check→ rc 0, 0 occurrences of U+FFFD in 1784 text files;ARCH_DOCS_BASE=origin/main node core/scripts/check-arch-docs.mjs→arch-docs: OK (7 changed file(s)).T1 0 37 3 4; hand-written budget 37 lines / 3 files;patches/ds-bot/topics.jsonuntouched;core/src/client/i18n.jsuntouched; the forbidden surface is 0 (core/src/host/0), with a positive control that returns 2 on host/about/project-board.Not run (and why): the full
TZ=UTC npm run verify. This box has onlyesbuildin the sharedcore/node_modulessymlink (no@deepseek-ai/*harness packages, andnpm ciwould replace that symlink), so the core suite cannot start here; CI at this tip carries the full suite.Checkpoint
{ "pr": 3264, "claim": "Dev", "issue": 3263, "summary": "In a zh window a decided meeting whose decision file is gone now reads 「决策文件已不在」 instead of the English decision file gone; an English window is unchanged. The only product change: the third argument of the one bt-project-missing span, now t('decision file gone'); the dictionary entry already existed, so i18n.js has no changed line and core/src/host/** is untouched. One test (the 38th) covers a missing path in both windows and a present path that is never translated: red first 38/37/1, after the fix 38/38/0. The client bundle and the three patch artifacts were regenerated, not hand-edited.", "files": [ "core/src/client/project-board.js", "core/test/project-board-view.test.js", "changelog.d/3114-cut-34-decision-file-gone.fixed.md", "core/client.js", "patches/ds-bot/0008-client-bundle.patch", "patches/ds-bot/files/src/client/project-board.js", "patches/ds-bot/files/test/project-board-view.test.js" ], "checks": { "ran": "project-board-view red 38/37/1 then green 38/38/0 + five i18n gates 41/41/0 + baselines 12/9/46 + npm run build + ds-bot-patches generate/canonical/check + build-client --check + changelog 15 + mojibake 1784 + arch-docs + risk gate T1 0 37 3 4", "result": "green", "at": "59e307580c973d515e891b2dfbe4529511273a6f" }, "next": "none — ready for review" }