Skip to content

Read the missing decision file in the window's language (#3114) - #3264

Merged
Birfy merged 1 commit into
mainfrom
dev/3114-decision-file-gone-zh
Nov 20, 2026
Merged

Birfy merged 1 commit into
mainfrom
dev/3114-decision-file-gone-zh

Conversation

@Birfy

@Birfy Birfy commented Nov 20, 2026 •

Copy link
Copy Markdown
Collaborator

Written-by: Dev
Fixes #3263
Part of #3114
Owner: Dev
Reviewer: Reviewer
Docs-not-needed: one literal swapped for t(); the dictionary entry already exists.

What changed

Before: in a zh window a decided meeting whose decision file is gone drew the bare English literal decision file gone in the Project board's record section. After: the same cell draws t('decision file gone'), so a zh window reads 「决策文件已不在」, while an English window is byte for byte unchanged. The dictionary entry already existed (core/src/client/i18n.js:1602, written by #1767), so i18n.js has 0 changed lines here.

Only the third argument of the one bt-project-missing span changed (core/src/client/project-board.js:651, +1/−1). The row still reads data-status="decided"; the question, the @speaker, bt-project-missing's CSS and prop, meeting.status (:663) and meeting.advance.reason (:661) are untouched; core/src/host/** is not touched — the host still answers path: '' and the row still disappears only when the meeting does. A non-empty path is still drawn as it came, never translated.

Verification at the tip

Tip SHA: 59e307580c973d515e891b2dfbe4529511273a6f (tree 695ba8aa7df2b7c8a660fad26a41a40c39eec246)

Ran at this tip:

$ cd core && TZ=UTC node --test test/project-board-view.test.js
# tests 38 / pass 38 / fail 0
$ cd core && TZ=UTC node --test test/i18n.test.js test/i18n-missing-entries.test.js test/i18n-template-draws.test.js test/i18n-plugins.test.js test/i18n-plugins-missing-zh.test.js
# tests 41 / pass 41 / fail 0
$ cd core && node -e 'for (const [f,w] of [["test/i18n-plugins.baseline.json",12],["test/i18n-template-draws.baseline.json",9],["test/i18n-missing-entries.baseline.json",46]]) { const n = JSON.parse(require("fs").readFileSync(f,"utf8")).entries.length; console.log(f, n, n===w?"ok":"MISMATCH") }'
i18n-plugins 12 ok / i18n-template-draws 9 ok / i18n-missing-entries 46 ok
$ node core/scripts/build-client.mjs --check            # rc 0
$ node scripts/ds-bot-patches.mjs check                 # ok 10 patches apply cleanly; ok core/ equals ds-bot/ + patches/ds-bot/ (pin skipped: no git here)
$ node .github/scripts/changelog.mjs check              # 15 fragment(s) are well formed
$ node .github/scripts/check-mojibake.mjs --check       # 0 U+FFFD in 1784 text files
$ grep -n 'decision file gone' core/src/client/project-board.js | grep -v "t('decision file gone')" | wc -l   # 0
$ node --input-type=module -e 'import{createGate,loadRules}from"./.github/scripts/risk-gate.mjs";const r=createGate(loadRules("./.github/agent/risk-rules.json")).judge([{filename:"core/src/client/project-board.js",additions:1,deletions:1},{filename:"core/test/project-board-view.test.js",additions:34,deletions:0},{filename:"changelog.d/3114-cut-34-decision-file-gone.fixed.md",additions:1,deletions:0},{filename:"core/client.js",additions:1,deletions:1},{filename:"patches/ds-bot/0008-client-bundle.patch",additions:1,deletions:1},{filename:"patches/ds-bot/files/src/client/project-board.js",additions:1,deletions:1},{filename:"patches/ds-bot/files/test/project-board-view.test.js",additions:34,deletions:0}]);console.log(r.tier,r.why.length,r.lines,r.files,r.generated)'
$ printf 'core/src/host/store.js\ncore/src/client/about.js\ncore/src/client/project-board.js\n' | grep -cE '^(core/src/host/|core/src/client/about\.js$|core/src/client/capability-settings\.js$|patches/ds-bot/topics\.json$|core/test/i18n-.*\.baseline\.json$)'

Every command above was run on a tree byte-equal to the tip; the red-first run is recorded in the PR comment and in red.txt/red-full.log.

Red first — only the test added, core/src/client/project-board.js at the merge base:

  • cd core && TZ=UTC node --test test/project-board-view.test.js → # tests 38 / # pass 37 / # fail 1; case 38 expected 决策文件已不在, actual decision file gone. Clean main on the same file is 37/37/0.

At the tip:

  • same command → # tests 38 / # pass 38 / # fail 0.
  • the five i18n gates (test/i18n.test.js test/i18n-missing-entries.test.js test/i18n-template-draws.test.js test/i18n-plugins.test.js test/i18n-plugins-missing-zh.test.js) → 41 / 41 / 0; the three baselines 12 / 9 / 46 ok.
  • cd core && npm run build regenerated core/client.js; node scripts/ds-bot-patches.mjs generate twice (idempotent, zero diff the second time); canonical → ok patches/ds-bot/ is what generate writes (generate is a no-op); check → three ok lines; node core/scripts/build-client.mjs --check → rc 0; git status --porcelain empty.
  • node .github/scripts/changelog.mjs check → 15 well-formed fragments; node .github/scripts/check-mojibake.mjs --check → rc 0, 0 occurrences of U+FFFD in 1784 text files; ARCH_DOCS_BASE=origin/main node core/scripts/check-arch-docs.mjs → arch-docs: OK (7 changed file(s)).
  • the risk gate on the seven changed paths → T1 0 37 3 4; hand-written budget 37 lines / 3 files; patches/ds-bot/topics.json untouched; core/src/client/i18n.js untouched; the forbidden surface is 0 (core/src/host/ 0), with a positive control that returns 2 on host/about/project-board.

Not run (and why): the full TZ=UTC npm run verify. This box has only esbuild in the shared core/node_modules symlink (no @deepseek-ai/* harness packages, and npm ci would replace that symlink), so the core suite cannot start here; CI at this tip carries the full suite.

Checkpoint

{
  "pr": 3264,
  "claim": "Dev",
  "issue": 3263,
  "summary": "In a zh window a decided meeting whose decision file is gone now reads 「决策文件已不在」 instead of the English decision file gone; an English window is unchanged. The only product change: the third argument of the one bt-project-missing span, now t('decision file gone'); the dictionary entry already existed, so i18n.js has no changed line and core/src/host/** is untouched. One test (the 38th) covers a missing path in both windows and a present path that is never translated: red first 38/37/1, after the fix 38/38/0. The client bundle and the three patch artifacts were regenerated, not hand-edited.",
  "files": [
    "core/src/client/project-board.js",
    "core/test/project-board-view.test.js",
    "changelog.d/3114-cut-34-decision-file-gone.fixed.md",
    "core/client.js",
    "patches/ds-bot/0008-client-bundle.patch",
    "patches/ds-bot/files/src/client/project-board.js",
    "patches/ds-bot/files/test/project-board-view.test.js"
  ],
  "checks": { "ran": "project-board-view red 38/37/1 then green 38/38/0 + five i18n gates 41/41/0 + baselines 12/9/46 + npm run build + ds-bot-patches generate/canonical/check + build-client --check + changelog 15 + mojibake 1784 + arch-docs + risk gate T1 0 37 3 4", "result": "green", "at": "59e307580c973d515e891b2dfbe4529511273a6f" },
  "next": "none — ready for review"
}

Docs-not-needed: one literal swapped for t(); the dictionary entry already exists.
@Birfy Birfy added the agent-pr Pull request opened by an agent label Nov 20, 2026
@Birfy Birfy self-assigned this Nov 20, 2026
@Birfy

Birfy commented Nov 20, 2026

Copy link
Copy Markdown
Collaborator Author

Written-by: Dev

三数(同一条命令,cd core && TZ=UTC node --test test/project-board-view.test.js):

  • 红先(只放测试、core/src/client/project-board.js 在 merge base):# tests 38 / # pass 37 / # fail 1,第 38 例 expected 决策文件已不在、actual decision file gone;干净 main 同文件是 37/37/0。
  • 绿(tip 59e307580c973d515e891b2dfbe4529511273a6f):# tests 38 / # pass 38 / # fail 0。
  • 五道 i18n 门 41 / 41 / 0;三基线 12 / 9 / 46。

档位(.github/scripts/risk-gate.mjs 的 judge(),七条改动路径):T1 0 37 3 4(why 0 条、手写 37 行 / 3 文件、生成 4 路径)。A16 预算命令 37 3;A14 mojibake: ok — 0 occurrences of U+FFFD in 1784 text file(s);A18 禁改面 0(core/src/host/ 0,正控 2);patches/ds-bot/topics.json 与 core/src/client/i18n.js 各 0 行;canonical / check / core/scripts/build-client.mjs --check rc 0;arch-docs: OK (7 changed file(s));changelog 15 片段。

未跑全量 TZ=UTC npm run verify:本机只有共享 esbuild,没有 @deepseek-ai/* harness 包,跑不起来;门与受影响测试都跑了。

按派活不自行入队,停在这里等复核。

@Birfy
Birfy added this pull request to the merge queue Nov 20, 2026
@Birfy

Birfy commented Nov 20, 2026 •

Copy link
Copy Markdown
Collaborator Author

Enqueue evidence — tip 59e30758

Written-by: enqueue
Read at 2026-11-20T11:00Z (UTC). Sources: REST /pulls/3264, /pulls/3264/files, /commits/59e30758/check-runs, /issues/3264/comments; node .github/scripts/risk-gate.mjs --repo ThinkFlowLab/FlyBot --pr 3264; tip/base tarballs diffed locally; GraphQL enqueuePullRequest / mergeQueueEntry.

Four checks

  1. Tier T1, route without PASS — risk-gate line risk-tier: T1 (basis: all 7 files T1); judge T1 0 37 3 4 (37 hand-written lines / 3 files, 4 generated).
  2. Tip checks (11:00:26Z) — 22 runs, all terminal: 20 success, 2 skipped (live · ubuntu · Node 24 · real model, window check), 0 failure / 0 cancelled.
  3. PR state — open, not draft, base main @ 422a672c, mergeable clean, no hold, label agent-pr, body Fixes #3263 + Part of #3114.
  4. Checkpoint — block 1452 chars (≤1500); pr=3264, claim=Dev, issue=3263, summary 596 (≤600), next 23 (≤300), files 7/7 all in this diff, checks green @ tip.

Seven spot-checks on the tip tree

  1. Files exactly 7, +73/−4: core/src/client/project-board.js +1/−1; core/test/project-board-view.test.js +34/−0; changelog.d/3114-cut-34-decision-file-gone.fixed.md +1/−0; core/client.js +1/−1; patches/ds-bot/0008-client-bundle.patch +1/−1; patches/ds-bot/files/src/client/project-board.js +1/−1; patches/ds-bot/files/test/project-board-view.test.js +34/−0.
  2. core/src/client/i18n.js not in diff; grep -c "'decision file gone'" core/src/client/i18n.js → 1 (:1602).
  3. Bare literal 0: grep -n 'decision file gone' core/src/client/project-board.js | grep -v "t('decision file gone')" | wc -l → 0; the file's only hunk is that 1-line argument change (:651).
  4. Host untouched: core/src/host/ → 0; patches/ds-bot/topics.json → 0.
  5. Not smuggled: meeting.status (:663), meeting.advance.reason (:661), about.js Star, capability-settings.js Could not connect: → 0 hits in this diff.
  6. Generated consistent: node core/scripts/build-client.mjs --check rc 0; node scripts/ds-bot-patches.mjs check → 2 ok + pin check skipped (no git in this sandbox); core/client.js:12838 and both patches/ds-bot/files/ mirrors carry the same t('decision file gone').
  7. changelog.d 15 fragments (main 14); node .github/scripts/changelog.mjs check → 15 well formed.

Red → green (own runs, two each)

  • red (project-board.js at base, new test kept): 38 / 37 / 1 — case 38 expected 决策文件已不在, actual decision file gone.
  • green (tip tree): 38 / 38 / 0.
  • five i18n gates: 41 / 41 / 0; baselines 12 / 9 / 46.

Queue

  • enqueued at 59e307580c973d515e891b2dfbe4529511273a6f (expectedHeadOid) 2026-11-20T11:01:33Z; entry MQE_lQDOVIxL0c8AAAABQpPHrs4ABOPczgQsDQs position 1, state QUEUED.

Merge result

  • Queue chain: QUEUED@1 11:01:33Z → AWAITING_CHECKS@1 11:02:09Z → merged 2026-11-20T11:04:44Z.
  • Merge commit 641faf101bcbebe5bbc946c95ef6b16b2f4e1f9b; main moved 422a672c → 641faf10.
  • merge_group on 641faf10: Test success (run 44724171100), Merge gate success (44724170844), Enqueue guard success (44724170973); policy-sign / judge / generated jobs also success.
  • #3263 → closed/completed 11:04:46Z, closed automatically by Fixes.
  • Push CI on 641faf10 (run 44724576486): failure — 6 jobs red at step Install DSH with npm E404 GET https://registry.npmjs.org/@earendil-works/pi-schema/-/pi-schema-1.6.0.tgz; tests-ok failed. Not attributable to this diff: the merge_group Test run of the identical tree was fully green, and the previous main push run (422a672c, 10:03Z) was success — an external npm-registry/install break that needs infra follow-up.

Merged via the queue into main with commit 641faf1 Nov 20, 2026
21 of 22 checks passed
@Birfy
Birfy deleted the dev/3114-decision-file-gone-zh branch November 20, 2026 11:04
@github-actions github-actions Bot removed the agent-pr Pull request opened by an agent label Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

项目看板:决策文件已不在的行按窗口语言显示(Cut 34)

1 participant