Fix research cancellation and remaining-frame review - #87
Merged
Merged
Conversation
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An active-series research request could cancel on a read-only viewer-state call when a localizer was visible beside it. Continue prepared a new run without submitting it, and restored coverage could appear beside a contradictory zero-image status. Whole-view sharing also exposed offscreen series capture.
Scope validation now filters read-only state and checks the targeted pane while keeping whole-view capture strict. Remaining-frame review submits the original request once, preserves the draft and cumulative coverage, and skips delivered frames. The sidebar separates model status from frames sent, clears old receipts on scope changes and shows the latest research result first. Known read failures no longer become uncertain mutations; cleanup preserves the original stop/pause reason.
PubMed accepts omitted/null limits and bounded counts up to ten, returns actionable validation/service errors and marks all-failed research honestly. Original failed arguments were unavailable, so this does not assert their exact cause.
Validation:
DOX and the study-exploration runbook were updated in the same change.
High-level PR Summary
This PR fixes critical issues in research request lifecycle management where active series research could incorrectly cancel during read-only viewer state calls when unshared panes (like localizers) were visible. The fix separates read-only state operations from scope validation, implements proper remaining-frame continuation that submits the original request once while preserving coverage and draft state, and improves PubMed error handling with actionable validation messages. The changes ensure whole-view capture remains strict while allowing filtered state reads, and preserve original stop/pause reasons during cleanup.
⏱️ Estimated Review Time: 30-90 minutes
💡 Review Order Suggestion
AGENTS.mdbackend/clinical/AGENTS.mdbackend/clinical/ai_exploration_contracts.pybackend/clinical/ai_exploration.pybackend/clinical/ai_exploration_coverage.pybackend/clinical/ai_codex.pybackend/clinical/ai_codex_tools.pybackend/clinical/ai_text.pybackend/clinical/ai_research_worker.pybackend/tests/AGENTS.mdbackend/tests/test_ai_codex_exploration.pyviewer/assets/live/protocol.tsviewer/assets/live/exploration.tsviewer/assets/live/study-capture.mjsviewer/assets/live/ohif.tsviewer/assets/live/controller.tsviewer/assets/live/exploration-panel.tsviewer/assets/live/panel.tsdesktop/src/study-capture.mjsdesktop/tests/study-capture.test.mjsviewer/assets/radsysx-viewer.cssdesktop/AGENTS.mddesktop/scripts/ui-import-smoke.mjsviewer/scripts/AGENTS.mdviewer/scripts/test-exploration.mjsviewer/scripts/test-live.mjsbackend/clinical/ai_fixture_server.pyroadmap/ai-backend/CODEX_STUDY_EXPLORATION.md