Fix image delivery and simplify the AI sidebar - #86
Merged
Merged
Conversation
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and behavior
Sharing a study could inventory 34 frames while delivering none: the Codex session retained conflicting text-only instructions, and pixels depended entirely on the model requesting them. Scoped turns now capture and attach initial images before the model answers, explicitly authorize the declared tools, and record accepted image delivery. Capture failure cannot silently downgrade to text-only inference.
The reading-room sidebar replaces Prepare sharing with Images + Send with images, captures fresh images on subsequent turns, keeps delivery and Stop/Take over near the composer, moves voice setup behind a header control, and collapses completed native activity. Preview images are created only with actual sources; the obsolete detector suppression was removed.
Native adaptations of the requested OpenMed workflows add scoped technical DICOM metadata, literal source-anchored report structuring, and richer PubMed abstract metadata plus saved query receipts. Existing report-save review and explicit Jev confirmation remain intact. These adaptations do not install NER models or add SR/full-text parsing.
Validation
This verifies transport and bounded workflows, not clinical accuracy or exhaustive viewer-tool/modality parity. Updated runtime guidance and runbooks record those limits.
High-level PR Summary
This pull request fixes a critical image delivery bug in AI-powered study exploration and simplifies the AI sidebar interface. Previously, sharing a study could inventory frames without delivering any pixels to the model. The fix ensures that scoped turns capture and attach initial images before the model responds, explicitly authorize declared viewer tools, and properly track image delivery. The sidebar UI was streamlined: the Prepare sharing step was removed in favor of an explicit Images selector with Send with images, fresh captures happen automatically on each turn, and delivery counts plus Stop/Take over controls remain visible near the composer. Voice setup moved behind a header button, and completed native activity is now collapsed. Three native tool adaptations inspired by OpenMed workflows were added: scoped technical DICOM metadata extraction, literal report structuring with exact source offsets, and enhanced PubMed search with structured abstracts, publication metadata, and query receipts. These additions do not install NER models or add SR/full-text parsing.
⏱️ Estimated Review Time: 30-90 minutes
💡 Review Order Suggestion
.impeccable/config.jsonAGENTS.mdCLAUDE.mdREADME.mdWARP.mdbackend/clinical/AGENTS.mdbackend/clinical/ai_codex_tools.pybackend/clinical/ai_codex.pybackend/clinical/ai_radiology.pybackend/clinical/ai_research_worker.pybackend/clinical/ai_fixture_server.pybackend/tests/AGENTS.mdbackend/tests/test_ai_radiology.pybackend/tests/test_ai_codex_exploration.pybackend/tests/test_ai_research.pyroadmap/AGENTS.mdroadmap/ai-backend/CODEX_STUDY_EXPLORATION.mdroadmap/ai-backend/OPENMED_ADAPTATIONS.mdviewer/assets/live/controller.tsviewer/assets/live/exploration.tsviewer/assets/live/exploration-panel.tsviewer/assets/live/panel.tsviewer/assets/radsysx-viewer.cssdesktop/AGENTS.mddesktop/scripts/ui-import-smoke.mjsviewer/assets/live/AGENTS.mdviewer/scripts/test-live.mjs