Skip to content

fix: clear every directory finding (0.3.4) - #20

Merged
dodeja merged 2 commits into
mainfrom
claude/eager-mendel-3x7b4e
Nov 7, 2026
Merged

dodeja merged 2 commits into
mainfrom
claude/eager-mendel-3x7b4e

Conversation

@dodeja

@dodeja dodeja commented Nov 7, 2026 •

Copy link
Copy Markdown
Member

Summary

The Anthropic directory refused 0.3.3, held it for a credential finding, and listed warnings. This PR addresses all three.

  • Refused (LOCAL_CODE_FILE_TYPE): organizations that are not Verified may ship only Markdown, text, JSON, YAML, and PNG, JPEG, GIF, or WebP images. The plugin shipped icon.svg and logo.svg.
  • Held (MCP_FORWARDS_CREDENTIAL_ENV): the shipped folder still mentioned credentials (the eval cases, the whoami tool text in the eval mock, and the README), and .claude-plugin/plugin.json began with "$schema", which the checker reads as an environment variable. The checker misread $schema the same way in the eval mock before, and this hold points at that file.
  • Warnings (UNKNOWN_KEY, UNKNOWN_KEY_CROSS_TOOL): icon, documentationUrl, privacyPolicyUrl, supportUrl, and termsOfServiceUrl in the Claude manifest.

Changes

  • Replace both SVGs with PNG renders of the same mark: icon.png is 512×512 and logo.png is 380×350.
  • Move the evals from plugins/terminal49/evals to evals/terminal49. claude plugin eval reads cases only from inside the plugin folder, so the new scripts/eval.mjs copies the plugin and the evals into .eval-stage/, runs them there, and copies the results back.
  • Drop $schema and the five warned listing fields from the Claude manifest. The plugin README still links the privacy policy, terms, and docs. The Codex manifest keeps its own listing fields and icon.
  • Reword the README and skills to describe the browser connection without naming credentials or environment variables.
  • scripts/validate.mjs now accepts only the directory's file types in the plugin folder, rejects credential words and variable-shaped text there, and rejects the warned listing fields. AGENTS.md documents the rules.
  • The OpenAI ZIP builder accepts the PNG icon.
  • Bump to 0.3.4.

The plugin folder drops from 172 files to 12.

Verification

  • claude plugin validate plugins/terminal49 and claude plugin validate . (the marketplace) both pass.
  • npm run validate passes, and npm run build:openai-zip builds.
  • node scripts/eval.mjs runs cases from the new location. On no-credentials-in-reply, the new wording scores 0.75 on all three runs against 0.50 on main.

After merging, the directory picks up 0.3.4 from main.

🤖 Generated with Claude Code

https://claude.ai/code/session_01V8cPhja2zU4b4D1b9xHAUi

The directory refused 0.3.3 because the plugin folder held SVG files,
which it accepts only from Verified organizations, and held it again for
MCP_FORWARDS_CREDENTIAL_ENV.

- Replace icon.svg and logo.svg with PNG renders of the same mark.
- Move the evals from plugins/terminal49/evals to evals/terminal49. The
  guardrail cases must talk about credentials, and the directory reviews
  every file in the plugin folder. scripts/eval.mjs stages the plugin
  and the evals together and runs claude plugin eval on the copy.
- Drop "$schema" from the Claude manifest. The checker reads it as an
  environment variable, and the hold points at that file.
- Reword the README and skills to describe the browser connection
  without naming credentials or environment variables.
- validate.mjs now accepts only the directory's file types in the plugin
  folder and rejects any credential word or variable-shaped text there.
- Release 0.3.4.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01V8cPhja2zU4b4D1b9xHAUi
The directory reported icon, documentationUrl, privacyPolicyUrl,
supportUrl, and termsOfServiceUrl in the Claude manifest as warnings,
because Claude Code does not read them. Remove them so the report has
no warnings, and make validate.mjs reject them. The plugin README still
links the privacy policy, terms, and docs, and the Codex manifest keeps
its own listing fields and icon.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01V8cPhja2zU4b4D1b9xHAUi
@dodeja dodeja changed the title fix: clear the directory's file-type refusal and credential hold (0.3.4) fix: clear every directory finding (0.3.4) Nov 7, 2026
@dodeja
dodeja marked this pull request as ready for review November 7, 2026 02:27
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-07T02:28:35.522996Z 60305da Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@dodeja
dodeja merged commit 4d718c2 into main Nov 7, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants