Fix repo path validation for framework-specific route segments - #1190
Open
sentry[bot] wants to merge 2 commits into
Open
Fix repo path validation for framework-specific route segments#1190sentry[bot] wants to merge 2 commits into
sentry[bot] wants to merge 2 commits into
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
tanstack-com | b793716 | Commit Preview URL Branch Preview URL |
Aug 29 2026, 11:03 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where certain framework-specific file paths, particularly those used in SvelteKit for dynamic routes (e.g.,
[postId]), were being rejected by theisValidRepoPathutility due to an overly restrictive regex.The
REPO_PATH_SEGMENT_PATTERNregex insrc/utils/repo-path.tspreviously did not allow characters like[,],(,), and@. This caused validation errors when attempting to load example files from frameworks that utilize these characters in their routing conventions.Changes Made:
REPO_PATH_SEGMENT_PATTERNinsrc/utils/repo-path.tsto include[,],(,), and@characters. The+character was also explicitly added to support SvelteKit's+page.svelteconvention.tests/repo-path.test.tsto ensure that SvelteKit bracket-style dynamic routes, Next.js/Remix parenthesis route groups, and@-prefixed directories are now correctly validated as valid repository paths.Fixes TANSTACK-COM-3ZT
This PR was automatically generated by Sentry. You can adjust this setting at any time.