Fix: Doc feedback hashing crashes on HTTP origins - #1189
Open
sentry[bot] wants to merge 1 commit into
Open
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
tanstack-com | 1b3e3ca | Commit Preview URL Branch Preview URL |
Aug 29 2026, 11:05 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a
TypeError: Cannot read properties of undefined (reading 'digest')that occurred when users accessed TanStack documentation over plain HTTP (non-secure origins).Problem: The
sha256Hexutility, located insrc/utils/hash.ts, is used to generate content hashes for document feedback blocks. This utility directly callscrypto.subtle.digest, which is part of the Web Crypto API. However,crypto.subtleisundefinedin non-secure browser contexts (i.e., when accessing pages via HTTP), leading to an unhandledTypeErrorand a page crash.Solution:
fnv1aHex) was added tosrc/utils/hash.ts. This hash is suitable for content identification where cryptographic security is not required, such as for doc feedback block IDs.sha256Hex: Thesha256Hexfunction was modified to check for the availability ofcrypto?.subtle. Ifcrypto.subtleis unavailable and the code is running in a browser environment (typeof window !== 'undefined'), it now falls back to usingfnv1aHex.This ensures that:
crypto.subtleAPI.crypto.subtleis always available and often required for database constraints), the cryptographically secure SHA-256 hash is still used, maintaining existing functionality and data integrity.Fixes TANSTACK-COM-408
This PR was automatically generated by Sentry. You can adjust this setting at any time.