[NellowTCS]

(needs hardware testing)

Summary by CodeRabbit

• New Features
  • Added a Clock app with responsive digital and analog displays.
  • Switch between clock styles when valid local time is available.
  • Digital displays follow the system’s 12- or 24-hour time setting and supported date formats.
  • When the time is unavailable, the app displays a prompt to connect to Wi-Fi.
• Documentation
  • Added an overview of the app’s displays, settings, controls, and licensing.

[coderabbitai]

Walkthrough

The changes add a Clock app with CMake and manifest configuration, system time and date format loading, and a saved analog-mode preference. The UI provides responsive digital and analog clock displays, with a Wi-Fi connection prompt when the local time is considered invalid. A one-second timer refreshes the display. The app handles window creation, destruction, and close events. The changes also add a README and GPLv3 license.

Merge Risk: Low · up to c1eec

The Clock app adds digital and analog faces and remembers the chosen mode. In the rare case that preferences cannot be opened, the selected mode is silently not saved and the app reverts to digital on the next launch. This is a small, bounded issue. Hardware testing is still noted by the author.

Pre-merge checks: 4

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title "Clock App" names the main change: this PR adds a new clock app under Apps/Clock, including its UI, settings, CMake build files, manifest, and license. The title is short and specific enough…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title "Clock App" names the main change: this PR adds a new clock app under Apps/Clock, including its UI, settings, CMake build files, manifest, and license. The title is short and specific enough for a teammate to identify the primary change, though it does not mention the digital/analog faces or the SDK build setup.

Finishing Touches

Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[coderabbitai]

Actionable comments posted: 1

Review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: f9651b32-77c6-4a02-971b-c39a7997dba2

Commits

Reviewing files that changed from the base of the PR and between a6bca74 and c1eecf8.

Files selected for processing: 10

• Apps/Clock/CMakeLists.txt
• Apps/Clock/LICENSE
• Apps/Clock/README.md
• Apps/Clock/main/CMakeLists.txt
• Apps/Clock/main/Source/Clock.cpp
• Apps/Clock/main/Source/ClockSettings.cpp
• Apps/Clock/main/Source/ClockSettings.h
• Apps/Clock/main/Source/ClockUi.cpp
• Apps/Clock/main/Source/ClockUi.h
• Apps/Clock/manifest.properties

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

[KenVanHoeylandt]

Nice addition, thank you!