fix(showcase): fence-kit and hand-pump visual quality pass - #183
Merged
Merged
Conversation
A hypot-length box rotated about its centroid misses one host and punches the other; braces and goosenecks have to be built from the stations they join. Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Build the brace from named post stations and U-wrap the rail collars so the bay reads as a fence instead of a hypot-box with coplanar straps. Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Replace the sausage-cylinder gooseneck and cube head with a tube from the column radius and a stuffing-box so the silhouette reads as a pump. Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reusable showcase visual-quality pass on
fence-kitandhand-pump(picks: no prior quality pass; last report named these next). One branch, three commits: convention, then each piece.New convention in
showcase/README.md: Diagonal from stations (exit 17) — brace / gooseneck / scroll from named host endpoints, not a hypot-length box rotated about its centroid.fence-kit
Intended size: 1.60 m bay, 1.14 m posts. Outer AABB 1.624 x 0.134 x 1.232 m.
Defects (round 1 inspection, old mesh)
joint_brace_l, threeq_a, clay).joint_brace_r).joint_strap,joint_post_rail).joint_kick, ground).POST_H(joint_cap).y = -POST_W*0.55(front, clay).Generator fixes (structural)
(post_xs[0], Y_BRACE, RAIL_ZS[0])to(post_xs[1], Y_BRACE, RAIL_ZS[-1])on the post back face, not a centroid-rotated hypot box.COLLAR_BITEso they cannot z-fight the rail ends.TENONpast the post inner face; kick seatsSHOE_H - 0.003into the shoes; caps added after the wood bevel with a 3 mm overlap.sin(i)jitter on rail Y/Z. Wear noise on both materials. No XY recenter.Round 2 inspection (looked at every PNG): brace meets both posts, caps eave the posts, kick is a toe board, clay reads as a fence. Remaining nits: U-straps are still three plates (intentional vs z-fight), shoes are box collars. 2 inspection rounds. Landing-page yes.
Hygiene / joint (live run, all three binaries)
Falsifiers (same code on 4.5.11, 5.1.2, 5.2.1)
--skip-decimate--stray-vert--lift-z/--short-shoes--short-brace--gap-rails--long-rails2·RAIL_HALFHero: 5.2.1 Cycles,
check_framingwith nodeviation=. fill y=0.872, margins min 0.033. Pillow webp q85.hand-pump
Intended size: ~1.05 m village pump, 0.34 m plinth, 0.76 m column. Outer AABB 0.610 x 0.382 x 1.052 m.
Defects (round 1 inspection, old mesh)
cyl_betweengooseneck (left ortho, threeq, clay,joint_spout_*).joint_head_handle, top).joint_plinth, ground).joint_spout_nozzle).Generator fixes (structural)
y0 = -COL_R_LO,t0 = -0.14so the join is inside the column volume.world_bboxfrom live verts. Wood grip added after plinth bevel. Wear noise. 4 flange bolts. Flared nozzle cone.Round 2 inspection (looked at every PNG): gooseneck is a continuous tube, head reads as a stuffing box, clay silhouette is a pump, plinth planted. Remaining nits: 6-gon cut at the column join, cube cheeks. 2 inspection rounds. Landing-page yes.
Hygiene / joint (live run, all three binaries)
Falsifiers (same code on 4.5.11, 5.1.2, 5.2.1)
--skip-decimate--stray-vert--lift-z--float-spout--float-flange--skinny-colCOL_R_LOHero: 5.2.1 Cycles,
check_framingwith nodeviation=. fill y=0.844, margins min 0.072. Pillow webp q85.Evidence
.scratch/blender-4.5.11-windows-x64,blender-5.1.2-windows-x64,blender-5.2.1-windows-x64(5.2.1 reports Blender 5.2.1 LTS). Inspection sheets in.scratch/inspect/round2/(untracked).python scripts/build_gallery.py.Test plan
needs-5.1(REST{\"labels\":[\"needs-5.1\"]})--adminMade with Cursor