Repository navigation
Reject equivalent Production URLs in tutorial readiness - #2
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (3)
Included review availability: This review used your included allowance. 1 included review remains after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. 📝 WalkthroughWalkthroughBoth setup scripts now report a missing Synth CLI with installation guidance and validate API endpoint URLs using parsed URL properties. Tests cover the missing CLI error and rejected endpoint forms. ChangesSetup check validation
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to No actionable issue is established in the setup checks. The change is mergeable after normal checks. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
Comment |
|
@coderabbitai review |
|
|
@coderabbitai review |
|
|
@coderabbitai review |
|
Change
Compare the parsed hostname rather than the literal URL. Reject Production host variants, malformed URLs, credentials in URLs, query strings and fragments before profile validation. The helper remains read-only and still requires explicit provisioned-context confirmation; it does not claim that an arbitrary endpoint is an authorized Dev account.
Proof
The new regression test first failed on seven cases, including the known Production host with :443 and a trailing DNS dot. The complete offline suite now passes (46 tests). No network or paid work is used by these tests. Both example copies match. Task, profile, plan and scoring bytes are unchanged.
Publish as a new immutable release; preserve the existing release and receipts.
Summary by CodeRabbit