Skip to content

waylandbridge: transform surface damage at commit time - #134

Draft
Leeestephen wants to merge 1 commit into
SuperTurtleDev:mainfrom
Leeestephen:fix/surface-damage-mapping
Draft

Leeestephen wants to merge 1 commit into
SuperTurtleDev:mainfrom
Leeestephen:fix/surface-damage-mapping

Conversation

@Leeestephen

Copy link
Copy Markdown
Collaborator

Summary

Accumulate surface-space damage separately from buffer-space damage and convert
it using the mapping state committed with the buffer. Apply buffer scale,
transform and viewport mapping, clip conservatively and combine the resulting
buffer rectangles. Carry mapping state through synchronized subsurface commits.

This fixes incorrect/stale uploads from scaled wl_surface.damage clients and
adds focused math coverage plus a scaled SHM client control.

Testing

The complete arm64/API35 daemon and SHM test client build against the
upstream-pinned Wayland source. Damage-mapping tests pass with ASan/UBSan on
the host and with assertions enabled in a standalone Android arm64 executable.
Coverage includes scale, transform, viewport source/destination, clipping,
extreme coordinates and rectangle union.

Earlier integrated scaled-SHM visual controls passed. A fresh live compositor
visual pass for this exact upstream-based extraction remains pending.

@Goldzxcbug

Copy link
Copy Markdown
Collaborator

From your description, it sounds like you have KDE desktop with xdg-desktop-portal installed. With that installed, it’s similar to what you described. Or you could try another desktop environment—this probably won’t happen there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants