Repository navigation
input: reconcile Android key mapping and seat modifier lifetime - #132
Draft
Leeestephen wants to merge 1 commit into
Draft
Leeestephen wants to merge 1 commit into
Leeestephen wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expand zero-scancode Android-to-evdev mapping for ordinary injected keyboards.
Reconcile fresh MotionEvent modifier snapshots before presses while preserving
modifiers backed by real key-down events. Release pressed keys before the active
keyboard owner leaves or dies, retain lock state and ignore stale-owner leaves.
This addresses missing non-UHID keyboard input and stale Ctrl state causing
ordinary browser tab taps to act like multi-selection. Upstream's window-relative
coordinate handling from #129 is retained in the extracted branch.
Testing
The release host APK and arm64/API35 daemon build successfully against the
upstream-pinned Wayland source. Seventy-five Android key-mapping assertions pass.
An ASan/UBSan host harness executes the actual keyboard-leave and modifier
functions, covering balanced releases, stale-owner cleanup, absent resources,
lock retention and genuinely held modifiers.
The integrated predecessor passed physical typing, intentional Ctrl+tap and
ordinary tab-touch acceptance. A fresh end-to-end GUI/input pass for this exact
upstream-based extraction remains pending.