Repository navigation
module: guard ROM-bound service-context overlays before mount - #130
Draft
Leeestephen wants to merge 1 commit into
Draft
Leeestephen wants to merge 1 commit into
Leeestephen wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent a stale Anland platform service-context overlay from surviving an
Android OTA and hiding new platform service labels.
Anland generates a complete
plat_service_contextsoverlay at installation.On my LineageOS 24 / Android 17 upgrade, the retained Android 16 overlay
mislabelled new services, including
allowlistandmedia.codeclist.generator,and caused repeated
system_servercrashes under enforcing SELinux.Changes
service mapping before the wildcard.
entry, supporting reinstall while the existing overlay is visible.
post-fs-data.sh, before the metamodule mount stage.Changed or unverifiable inputs create
disableandskip_mountmarkers.executable hook permissions during installation.
script and packaging regressions.
Testing
daemon/audio fixture payloads.
repeated successfully under
/system/bin/sh.reinstall over a visible overlay and persistent disable markers.
Run the host regressions with
An earlier device-local implementation passed an enforcing Android 17 cold
boot. This exact extracted revision still needs a fresh flash/cold-boot check.
The guard depends on the root implementation and metamodule honoring the
pre-mount hook and disable/skip-mount markers.
Contributor workflow
For future small, tested fixes, do you prefer contributors to wait for review,
or is self-merging acceptable after an agreed review window?