Skip to content

Remove the stale pfsa-db01-gb-dev alembic directory - #160

Merged
monodera merged 2 commits into
mainfrom
u/monodera/remove-stale-alembic-dev-dir
Oct 15, 2026
Merged

monodera merged 2 commits into
mainfrom
u/monodera/remove-stale-alembic-dev-dir

Conversation

@monodera

Copy link
Copy Markdown
Contributor

Since the filter_u/filter_v revisions (2026-05), the development database (pfsa-db:5437/targetdb_dev) has been migrated from alembic/pfsa-db01-gb/, the same directory as production, by switching TARGETDB_CONF. alembic/pfsa-db01-gb-dev/ stopped at a251bdccb11f. Dev is now at 03091e870c70, which exists only in pfsa-db01-gb/, so running alembic from the old directory against dev fails.

Changes

  • Remove alembic/pfsa-db01-gb-dev/. Nothing is lost:
    • Its 47 revision scripts and env.py are byte-identical to those in pfsa-db01-gb/.
    • The only difference was the placeholder sqlalchemy.url in alembic.ini, which is unused when TARGETDB_CONF is set.
  • Drop the directory from CLAUDE.md, alembic/README.md and docs/getting_started.md. The alembic README keeps one sentence noting that it existed and that its revisions are all in pfsa-db01-gb/.

Nothing else referenced the directory by name. The lint workflow passes alembic as a directory, and the pre-commit and pyproject.toml exclusions use wildcards.

Testing

  • ruff and black pass on src, tests and the remaining env.py scripts.
  • mkdocs build succeeds.

🤖 Generated with Claude Code

monodera and others added 2 commits October 14, 2026 19:28
Dev has been migrated from pfsa-db01-gb/ since the filter_u/filter_v
revisions, and it is now at a revision that exists only there, so this
directory could no longer be run against dev. Its 47 revision scripts
and env.py are byte-identical to those in pfsa-db01-gb/; only the
placeholder URL in alembic.ini differed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@monodera
monodera merged commit a7865c5 into main Oct 15, 2026
@monodera
monodera deleted the u/monodera/remove-stale-alembic-dev-dir branch October 15, 2026 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant