fix: complete Swarm harvest cleanup and add readiness diagnostics - #12
Conversation
Reconcile completed slot state before automatic archive and recognize Herdr's background done state as settled. Add read-only installation diagnostics and source validation that checks every shell script and Node module, with real-git regressions and isolated Herdr 0.8.2 workflow evidence.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (13)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe change reconciles Harvest state before archive, accepts Herdr ChangesHarvest and validation updates
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix · Severity of issue fixed: Low Suggested reviewers: Merge Risk: ⚪ Minimal · up to No actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 8 files. (5 skipped: 5 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
A pane-backed slot could merge successfully and then fail automatic archive because its plugin-reported state was still working; Herdr 0.8.2 additionally reports unseen idle agents as done. Harvest now refreshes completed state before archive and recognizes done as settled while retaining ownership, worktree, and active-agent checks.
Adds read-only
npm run doctordiagnostics andnpm run build/npm run validatecommands. Source validation checks each shell script individually, avoiding the first-file-only behavior ofbash -n scripts/*.sh, and checks Node module syntax. Documentation now points to the canonical suite site and records the bounded live workflow and remaining recommendations. Version stays 0.3.0 with changes under Unreleased.Validation:
npm run validateon Node 24: 244 tests pass, including all source/manifest/ShellCheck gates. Baseline Node 26 suite also passed (237 tests before these additions).The existing newer-than-tested warning remains: the 0.8.2 smoke run does not certify every CLI surface or model-agent integration. No CI/CD changes or global Herdr configuration changes.