Skip to content

Handle kCloglogOrdinal model more thoroughly - #420

Merged
andrewherren merged 2 commits into
StochasticTree:mainfrom
MichaelChirico:loglog-ordinal
Oct 5, 2026
Merged

andrewherren merged 2 commits into
StochasticTree:mainfrom
MichaelChirico:loglog-ordinal

Conversation

@MichaelChirico

@MichaelChirico MichaelChirico commented Aug 13, 2026 •

Copy link
Copy Markdown
Contributor

This is related to some observed crashes where init_val winds up uninitialized, e.g.

https://github.com/StochasticTree/stochtree/blob/main/test/R/testthat/test-predict.R#L686

Written by Gemini. I can share some more thorough diagnostics if needed.

@andrewherren
andrewherren merged commit fba0408 into StochasticTree:main Oct 5, 2026
16 checks passed
dwachsmuth added a commit to Curbcut/nashtree that referenced this pull request Nov 12, 2026
Ports StochasticTree/stochtree StochasticTree#417, StochasticTree#418, StochasticTree#420, StochasticTree#421 and the
exact-posterior MCMC test from StochasticTree#431. The cloglog active-forest
initializer no longer reads an uninitialized starting value; seeded
draws are bitwise unchanged. The Eigen 5 upgrade is deliberately not
ported (see NASH-FORK.md).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants