Repository navigation
Fix wrapper memory-safety bugs and builder option/terminals bugs - #37
Merged
Merged
Conversation
C++ wrapper: - RAII GIL guard and PyObject refs so every exit path releases the GIL - Fix double Py_DECREF after a Python exception (use-after-free on free) - Report Python errors with full traceback; stop PyErr_Print swallowing them - Bounds-check lists returned by getters instead of reading past the end - Always write doStep outputs; honour eventHandlingNeeded/earlyReturn - Release overwritten FMU states and SetFMUState results - Fix log buffer leaks, Component leak on failed instantiation, NULL log callback crash, and decode file:// resource URIs fully - Read the slave class name from slavemodule.txt (regex as fallback) Python: - to_xml used a stale loop value for CoSimulation/ModelExchange options - --terminals packed the wrong file into terminalsAndIcons/ - np.reshape(newshape=...) fails on NumPy >= 2.5 - Builder finds the FMU class by inspection and records it in the FMU Tests: builder regressions and a ctypes driver exercising the wrapper. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X8Wmw797DJpgrMFmT6n8CG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
C++ wrapper:
Python:
Tests: builder regressions and a ctypes driver exercising the wrapper.