Repository navigation
Fix encrypted connection decrypt failures and stale CMClient events - #1658
Merged
Merged
Conversation
xPaw
force-pushed
the
cm-connection-fixes
branch
from
November 5, 2026 10:04
39c4dfe to
d446eac
Compare
yaakov-h
reviewed
Nov 5, 2026
Member
|
If somebody asks why I'm merging this, it's totally not related to xPaw holding me at gunpoint or something, I promise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1005.
EnvelopeEncryptedConnectiondisconnects when an incoming packet fails to decrypt, instead of the exception being logged by the transport's read loop while it keeps reading a stream it can no longer decrypt.CMClientignoresConnectedandNetMsgReceivedfrom a connection that has already been released, so a late event no longer dereferences a null connection or processes messages afterDisconnected.