Repository navigation
Fix WebSocket connection teardown throwing and leaving stale state - #1657
Merged
Merged
Conversation
xPaw
force-pushed
the
websocket-teardown
branch
from
November 5, 2026 10:04
7e72cf4 to
7c3b93d
Compare
yaakov-h
reviewed
Nov 5, 2026
xPaw
force-pushed
the
websocket-teardown
branch
from
November 5, 2026 12:09
7c3b93d to
dc71c29
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1656.
WebSocketContext.Disposeno longer runs a close handshake.RunSynchronouslyonCloseAsyncthrew whenever the socket was open, soDisconnectedwas never raised andCMClient.IsConnectedstayed true.Sendonly disconnects the context it was sent on.Connectedhandler disconnects, a throwingNetMsgReceivedhandler is logged, as inTcpConnection.Connectno longer throws when the handshake fails synchronously.WebSocketConnectionandSteamClient.