Repository navigation
ci: pin the validator CLIs in a lockfile - #6
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 3 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aikido flags this repo for a missing lockfile. CI was installing claude-code, codex, ajv and ajv-formats ad hoc, top level versions pinned but transitive deps floating and nothing for Aikido to scan.
Moves them into scripts/package.json with a lockfile and every job does
npm cifrom that. It's in scripts/ rather than the root because Claude Code runs npm install on a plugin's root package.json when you install it, tried it and every user would have pulled ~560MB of CI tooling! The claude and codex jobs install into $RUNNER_TEMP too sinceplugin marketplace add "$PWD"copies the whole dir, node_modules included.Ran every job locally against this branch, all pass and the plugin cache after install is back to 148K.