Repository navigation
Conversation
There was a problem hiding this comment.
No issues found across 6 files
Requires human review: Switches SDK build to native TypeScript 7.0.2 (from 5.8.3) via gen.yaml/package.json/lockfile/docs and a read-only parity-check workflow. Human sign-off needed on a new major build compiler; parity/perf claims are not fully evidenced in the diff.
View guided diff | Turn on auto-fix | Re-trigger cubic
|
Thanks for reviewing d7403b0. The current-head validate job now completed on Ubuntu with Node 22.22.0/npm10.9.4: ordinary npm ci installed 130 packages, native build and existing ESLint passed, and the checked-in validation script compared all 4,284 emitted paths with identical JavaScript/public declaration bytes against retained TypeScript 5.8.3. The PR body contains every paired local sample, exact compiler commands, scope and contended-host limitations; independent security and Forge reviews found no actionable issues. Full Speakeasy regeneration remains unverified and is stated explicitly. Your human sign-off recommendation is retained; no approval or merge is being performed. |
There was a problem hiding this comment.
0 issues found across 3 files (changes from recent commits).
Requires human review: Switches the SDK build to native TypeScript 7.0.2 (from 5.8.3) via gen.yaml, package.json, lockfile, and docs, adding a read-only CI job. The major compiler upgrade's parity/perf claims are only asserted in the description and the parity check was removed.
View guided diff | Turn on auto-fix | Re-trigger cubic
|
The migration-only validator was intentionally removed in The compiler and output-parity comparison remains one-off migration evidence: it passed locally and in the earlier hosted job 114137895746. This cleanup changes no compiler version, dependency graph, build option or generated SDK source, so the recorded benchmark and byte-identical JavaScript/public declaration comparison remain applicable. Full Speakeasy regeneration was not run. Human sign-off for the major compiler upgrade remains required; no automated approval is claimed. |
The existing SDK emit build uses TypeScript 5.8.3. This changes
npm run buildto native TypeScript 7.0.2 through an explicit alias, while retaining 5.8.3 for ESLint's compiler API. The alias and build script are configured in the canonical rootgen.yamland mirrored in the generated package/normal npm lock so Speakeasy can reproduce them. The SDK release version is unchanged.CI scope: this PR introduces no workflows or jobs. The compiler-migration workflow additions have been removed, and pre-existing workflows are unchanged. This deletion changes no compiler, dependency graph, source or benchmarked command, so the recorded performance measurements remain applicable. Hosted results and bot reviews below refer to the earlier commits explicitly linked; they are not claims about the cleanup commit. The cleanup independently passed diff/reference checks and a scoped security/Forge review.
--rootDir srcpreserves the existing emitted file layout, and--types estree,json-schemapreserves the two ambient declaration packages discovered by the legacy compiler. Strictness and compiler source selection stay unchanged. Both packages expose atscbinary, so documented commands select them explicitly.The migration-only pull request workflow has been removed. Existing generation, publishing and tagging workflows are unchanged. Output comparisons and compiler-version assertions remain one-off migration evidence; there is no committed migration validator or new recurring CI job.
Local full emit benchmark
88.18% less time, 8.46× as fast, 14.451s saved per measured full emit. This is a local compiler measurement, not total CI duration.
macOS arm64, 14 logical CPUs, Node 22.22.0. Two warmup pairs precede seven measured pairs, with execution order alternating. All 18 compiler processes exit 0. The unchanged configuration has
incremental: false; each process performs a full emit while filesystem/OS caches remain warm and emitted files are overwritten in place. npm startup and output cleanup are excluded. Other audit agents paused heavy jobs, but unrelated host load remained high (one-minute observations about 28–49); no idle-host or universal speedup claim.Both actual selected binaries were version-asserted during this one-off benchmark. The original command/options and final native command check identical closures: 1,071 project source files and 16 non-compiler dependency declaration files. The measured checkout was isolated from unrelated parent-workspace ambient packages.
Reproduce after
npm ciin a fresh checkout without unrelated ancestornode_modules:Warm each command twice, then collect seven pairs while alternating which runs first. Keep the same installed graph and source tree throughout.
Validation and boundaries
StackOneexport load pass without making API requests. This repository has no test script or checked-in unit tests, so no unit-suite pass is claimed.mappings; file/source names, paths and content remain identical.npm ci --dry-runpasses; a complete ordinary localnpm cidid not dispatch. That installation boundary is now closed by the successful hosted normalnpm cidescribed below.Full raw timings, load samples, scope identities and validation/security reports are retained in the task's
continuation/evidence/generated-sdkdirectory; reproduction driver:continuation/benchmark_generated_sdk.py.Historical hosted validation and review
Cleanup commit
48d79b6280470d98eb9dd14b5b99d14448445377removes the migration validator and its CI invocation. It changes no compiler version, dependency graph, build option or generated SDK source, so the accepted benchmark and one-off output comparison remain applicable without a new timing run.The historical validate job passed on Ubuntu 24.04.5, Node 22.22.0 and npm 10.9.4 using GitHub's synthetic merge of this head into the unchanged base. Normal
npm ciinstalled 130 packages;npm run buildandnpm run lintboth passed. That migration-only workflow is now removed; this successful run is historical evidence, not an ongoing CI gate. No dual-compiler execution, exact-version assertion or output-parity validator was retained.The earlier hosted migration validation on
d7403b0ea8031f7a3eda5ed5e25883e20b4fb3bcalso passed the one-off generator/output comparison. That historical evidence and the local raw results remain retained; they are not a recurring maintenance contract. Full Speakeasy regeneration remains unverified.Previous-head Cubic review 5478608340 found zero code issues across the three cleanup files and still explicitly requests human sign-off for the major compiler migration. It is a
COMMENTEDreview, not an approval. Independent cleanup security review and the final Forge review found no actionable issues. Copilot exhausted its quota on the earlier head; no previous-head Copilot check or completed Copilot review is claimed, and no retry was requested. No approval or merge was performed by an agent.No code-scanning pass is claimed: Code scanning Needs setup, Secret scanning is Disabled, and Dependabot is enabled. Current hosted npm audit reports 16 vulnerabilities (14 high, 2 moderate); the earlier GitHub default-branch notice reports 11 alerts. These are separate inventories. Original package records are unchanged, and no audit fix or scanner-setting change was performed.