Repository navigation
ci: publish ADK releases from reviewed main with PyPI trusted publishing - #31
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ADK releases currently have no publishing workflow. This adds a manual release workflow that runs from reviewed main, builds an existing release tag, and uploads the tested wheel and source archive through PyPI Trusted Publishing without a stored token.
Publishing is restricted by both the workflow and the GitHub
pypienvironment to branchmain. Tag pushes do not publish. Before package tooling runs, the workflow resolves the selected commit and the fully qualified remote main reference to commit IDs and verifies ancestry. Package metadata is then parsed with isolated Python and uv configuration discovery disabled. The separate publishing job alone receives the identity permission.RELEASING.mddocuments the exact PyPI publisher fields and the manual first-release procedure forv0.3.0at47b20e6eb90aa7d36a87a0df6720ae37cf1feb44. The live GitHub environment has been tightened to allow branchmainonly; thev*tag rule was removed.Validation: actionlint and whitespace checks pass. All 11 local behavioral probes pass, covering current/historical releases, unmerged source, an impersonating
origin/maintag, wrong package names, version mismatches, malformed tags, missing main, checkout-local Python modules, local uv configuration, and combined attacks. On commit40b88ae, CI passes lint, typing, and tests on Python 3.11, 3.12, and 3.13. The release build passes tests, builds both distributions, and installs/imports each in an isolated environment. Publishing is correctly skipped on the PR. Aikido’s PR security check passes.The changes address findings from the StackOne review skill and independent built-in Codex review. Authenticated PyPI publisher configuration and the actual identity exchange/upload remain unverified. No release tag or package upload has been created.
Refs ENG-3325.