Skip to content

ci: publish ADK releases from reviewed main with PyPI trusted publishing - #31

Merged
glebedel merged 3 commits into
mainfrom
ci/adk-trusted-publishing
Oct 30, 2026
Merged

glebedel merged 3 commits into
mainfrom
ci/adk-trusted-publishing

Conversation

@glebedel

@glebedel glebedel commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

ADK releases currently have no publishing workflow. This adds a manual release workflow that runs from reviewed main, builds an existing release tag, and uploads the tested wheel and source archive through PyPI Trusted Publishing without a stored token.

Publishing is restricted by both the workflow and the GitHub pypi environment to branch main. Tag pushes do not publish. Before package tooling runs, the workflow resolves the selected commit and the fully qualified remote main reference to commit IDs and verifies ancestry. Package metadata is then parsed with isolated Python and uv configuration discovery disabled. The separate publishing job alone receives the identity permission.

RELEASING.md documents the exact PyPI publisher fields and the manual first-release procedure for v0.3.0 at 47b20e6eb90aa7d36a87a0df6720ae37cf1feb44. The live GitHub environment has been tightened to allow branch main only; the v* tag rule was removed.

Validation: actionlint and whitespace checks pass. All 11 local behavioral probes pass, covering current/historical releases, unmerged source, an impersonating origin/main tag, wrong package names, version mismatches, malformed tags, missing main, checkout-local Python modules, local uv configuration, and combined attacks. On commit 40b88ae, CI passes lint, typing, and tests on Python 3.11, 3.12, and 3.13. The release build passes tests, builds both distributions, and installs/imports each in an isolated environment. Publishing is correctly skipped on the PR. Aikido’s PR security check passes.

The changes address findings from the StackOne review skill and independent built-in Codex review. Authenticated PyPI publisher configuration and the actual identity exchange/upload remain unverified. No release tag or package upload has been created.

Refs ENG-3325.

Copilot AI balanced review requested due to automatic review settings October 30, 2026 10:52

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.

@glebedel glebedel changed the title ci: publish ADK releases with PyPI trusted publishing ci: publish ADK releases from reviewed main with PyPI trusted publishing Oct 30, 2026
@glebedel
glebedel merged commit 5513cfe into main Oct 30, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants