Skip to content

ci(SEC-104): bump Node to 22.23.4 for CVE-2026-111497 - #30

Merged
glebedel merged 2 commits into
mainfrom
s2d2/sec-104-ci-node-bump
Oct 26, 2026
Merged

glebedel merged 2 commits into
mainfrom
s2d2/sec-104-ci-node-bump

Conversation

@glebedel

@glebedel glebedel commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

What

Bumps the Node.js version pinned in this repo's GitHub Actions to 22.x.

File Line From To
.github/workflows/release.yml 16 18.x 22.x
.github/workflows/build.yml 10 18.x 22.x

Why

CVE-2026-111497 ("Node2Shell") is an out-of-bounds write in the Brotli decoder of node:zlib that can lead to remote code execution. It is fixed in Node 22.23.4, 24.22.1 and 26.12.1 (21 Oct 2026 security release). Production runtimes were patched under SEC-104; this PR covers the CI runners and build steps, which still pinned an affected version.

Node 18 and 20 are end of life and get no fix, so those pins move to Node 22. That is a major version change for these jobs: if a job fails here on engines or a native dependency, that is the reason.

Verification

Only the version strings above change; no other workflow logic is touched. Jobs that run on pull_request exercise the new version on this PR. Jobs that only run on push to main (deploys, releases) first use it after merge.

Follow-up commits

  • Floating major pins (22, 22.x, 24) are now exact (22.23.4 / 24.22.1). setup-node defaults check-latest to false, so a floating major can resolve to a cached build that predates the fix.

Requested by guillaume@stackone.com in Slack (SEC-104 follow-up).

🤖 Generated with Claude Code

Refs SEC-104.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings October 26, 2026 14:27

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Auto-approved: Bumps Node.js in CI workflows from 18.x to 22.x to address an EOL CVE; the diff is confined to two version strings with no workflow logic changes.

View guided diff | Turn on auto-fix | Re-trigger cubic

@glebedel glebedel changed the title ci: bump Node to 22.x for CVE-2026-111497 ci(SEC-104): bump Node to 22.x for CVE-2026-111497 Oct 26, 2026
setup-node defaults check-latest to false, so a floating 22 can resolve to a
cached Node 22 older than 22.23.4. Addresses review feedback.

Refs SEC-104.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 2 files (changes from recent commits).

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Auto-approved: Bumps Node.js in CI workflows from EOL 18.x to the patched 22.23.4 to address CVE-2026-111497; the diff changes only two version strings with no other workflow logic altered.

View guided diff | Turn on auto-fix | Re-trigger cubic

@glebedel glebedel changed the title ci(SEC-104): bump Node to 22.x for CVE-2026-111497 ci(SEC-104): bump Node to 22.23.4 for CVE-2026-111497 Oct 26, 2026
@glebedel
glebedel merged commit c05bfe8 into main Oct 26, 2026
3 checks passed
@glebedel
glebedel deleted the s2d2/sec-104-ci-node-bump branch October 26, 2026 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants