Skip to content

ci(ENG-3243): move action pins off the deprecated Node 20 runtime - #28

Merged
elgordomac merged 1 commit into
mainfrom
gordon/eng-3243-node20-action-pins
Oct 9, 2026
Merged

elgordomac merged 1 commit into
mainfrom
gordon/eng-3243-node20-action-pins

Conversation

@elgordomac

@elgordomac elgordomac commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Moves every JavaScript action in this repo's workflows that declares the Node 20 (or older) runtime to a release that runs on Node 24, removing the "Node.js 20 is deprecated" annotations GitHub adds to every job that uses one. Part of ENG-3243, which has done the same across the org.

Action From To Pins
actions/checkout v2.7.0, v3.6.0 v5.0.0 (08c6903) 2
actions/setup-node v1.4.6, v3.9.1 v6.3.0 (53b8394) 2

Compatibility

  • checkout v6 stores the persisted credential under $RUNNER_TEMP instead of .git/config; git commands keep working. Workflows here that push (git push/tag, create-pull-request, release tooling) take v5 instead, which is Node 24 but keeps the credential in .git/config, so their push path is unchanged.
  • setup-node v5/v6 auto-enables caching only when package.json declares an npm packageManager; none does here, and steps that cache already set cache:.
  • The remaining bumps are same-major or majors whose only breaking change is Node 24 itself. All need runner v2.327.1+, which GitHub-hosted and WarpBuild runners already meet.

Testing

Workflow-only change. Steps that only run on push, release, deploy or schedule aren't exercised by this PR's CI and will first run on merge.

🤖 Generated with Claude Code


Summary by cubic

Moves the actions/checkout and actions/setup-node pins in build.yml and release.yml to releases that run on Node 24, clearing GitHub's "Node.js 20 is deprecated" job annotations.

Compatibility

  • actions/checkout goes to v5 (not v6) so workflows that push keep credentials in .git/config; v6 stores them under $RUNNER_TEMP.
  • actions/setup-node v6 auto-enables caching only when package.json declares an npm packageManager; that isn't the case here.
  • Workflow-only change: steps that run only on push, release, deploy, or schedule aren't exercised by this PR's CI.

Written for commit bf5e670. Summary will update on new commits.

View guided diff Turn on auto-fix

Swap every JavaScript action that still declares the node20 (or older)
runtime for a release that declares node24, keeping this repo's pin
style. Workflows that push take checkout v5 rather than v6, so their
credential handling is unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings October 8, 2026 12:40

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Both workflows consistently use immutable pins for the intended Node 24-based action releases without changing workflow behavior.

0 open findings

What changed in this PR

Updates GitHub Actions to Node 24-based releases, eliminating deprecated Node 20 action runtimes.

Changes:

  • Upgrades pinned actions/checkout to v5.0.0.
  • Upgrades pinned actions/setup-node to v6.3.0.
File Description
.github/​workflows/​build.yml Updates build workflow action pins.
.github/​workflows/​release.yml Updates release workflow action pins while retaining checkout v5 credential behavior.

🧠 Review effort: Balanced


Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Auto-approved: CI-only update of checkout/setup-node pins to Node 24 runtimes in build/release workflows, removing GitHub's deprecated-Node-20 annotations; checkout stays on v5 to preserve push credentials, keeping the change bounded.

View guided diff | Turn on auto-fix | Re-trigger cubic

@elgordomac
elgordomac merged commit 1934765 into main Oct 9, 2026
4 checks passed
@elgordomac
elgordomac deleted the gordon/eng-3243-node20-action-pins branch October 9, 2026 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants