Repository navigation
Conversation
One source per repo: devEngines.runtime 22.23.4 (onFail: warn) is read by setup-node (node-version-file: package.json) in CI. Refs SEC-104. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
glebedel
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
.nvmrctopackage.jsondevEngines.runtimeand deletes.nvmrc.node-version-file: package.json. setup-node v6.3 and later readdevEngines.runtimebeforeengines.node, so CI gets the exact version, not the newest match of theenginesrange.onFail: "warn": npm warns on a mismatch instead of failing, so a local Node that is a patch behind is flagged without blocking work. CI stays exact through setup-node.Why
One place for the Node version, read by CI and by the package manager.
.nvmrcis only read by nvm and setup-node, and anenginesrange alone would let CI float to whatever release is newest. Docker base images are pinned separately and are unchanged.Local verification
Refs SEC-104. Requested by guillaume@stackone.com in Slack.
🤖 Generated with Claude Code
Summary by cubic
Moves the pinned Node version (22.23.4) from
.nvmrctopackage.jsondevEngines.runtimeso the version has a single source of truth read by both npm and CI..nvmrcis deleted and both workflows now pointnode-version-fileatpackage.json;setup-nodereadsdevEngines.runtimebeforeengines.node, so CI installs the exact pinned version instead of the newest release matching the range.onFail: "warn"flags a patch-behind local Node as a warning without blocking work.Written for commit dd45571. Summary will update on new commits.