Repository navigation
Conversation
Delete src/main.py, src/api/portfolio.py and src/models/portfolio.py — a FastAPI stub (in-memory portfolio CRUD + placeholder pricing) that nothing imports: verified no references in the TypeScript sources, package.json, Dockerfile, docker-compose.yml or GitHub workflows, and no Python tooling config (pyproject.toml/setup.py/Pipfile/tox.ini) exists in the repo. requirements.txt is intentionally left unchanged: fastapi/uvicorn are the stranded prototype's own dependencies, and the only other Python surface in the repo is the generated OpenAPI client (package.json openapi:client:python -> sdks/python), which is unrelated to src/. Removing those two lines is a one-line follow-up if you want it gone too — happy to add it here on request. Verified: npx tsc --noEmit passes; full jest suite 99/108 suites pass, and the 9 failing suites (auth, rate-limiting, websocket stress, azure-blob storage, random-id) fail identically on unmodified main in this environment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #199 — removes the stranded Python/FastAPI prototype from
src/, the last unchecked cleanup item in ALIAN_AUDIT.md §6.What changed
Deleted (nothing else touched):
src/main.py(FastAPI app with placeholder routes)src/api/portfolio.py(in-memory portfolio CRUD router, hardcoded1.0pricing)src/models/portfolio.py(pydantic models)The now-empty
src/api/andsrc/models/directories go with them.Why it's safe
package.json,Dockerfile,docker-compose.yml, or GitHub workflows, and there is no Python tooling config (pyproject.toml/setup.py/Pipfile/tox.ini) anywhere.openapi:client:python→sdks/python), which is unrelated tosrc/.requirements.txt— deliberately left unchangedThe issue's acceptance list says it "can be revised or removed if no longer needed."
fastapi/uvicornin it are this prototype's own dependencies, so with the prototype gone they serve nothing — but rather than unilaterally deleting a file other tooling might read, I left it untouched. Say the word and I'll remove it (or trim those two lines) in this PR.Verification
npx tsc --noEmit→ passes (exit 0).npm test(full jest suite) → 99/108 suites pass (1218/1233 tests). The 9 failing suites —core/auth/{challenge,enhanced-auth,enhanced-auth.credentials},rate-limiting/{guard,middleware,service},dashboard/websocket/websocket.stress,infrastructure/file-upload/storage/azure-blob-storage.backend,common/utils/random-id— fail identically on unmodifiedmainin this environment (verified by running those exact 9 suites against a cleanmaincheckout; the Azure suite needs cloud credentials and the rate-limit/websocket ones are timing-sensitive). This diff touches no TypeScript, so it cannot affect them either way.