Repository navigation
feat(fx): drawOGBubbleFrame iridescent deformation + OGFireflySpec scroll velocity (1.48.0) - #10
Merged
Conversation
…roll velocity (1.48.0)
Bubble: add scaleX/scaleY (withTransform squash) and ripplePhase/rippleAmp (3-layer
Newton-ring iridescent shimmer — cyan/magenta/gold ovals before rim+specular). Guards:
early-return on r<=0, iriAlpha clamped to [0,1] to satisfy Color.copy contract.
Firefly: add scrollVX/scrollVY Float=0f to OGFireflySpec (serializable, back-compat).
OGFireflyState.update() adds scrollV{X,Y}*dtC to per-fly position on top of Brownian
drift; frac() gives toroidal wrap. Codec prompt updated.
Reviewed by Fable. 1572 JVM tests green.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
drawOGBubbleFramegainsscaleX/scaleY(volume-preserving squash viawithTransform) andripplePhase/rippleAmp(3-layer Newton-ring iridescent shimmer: cyan / magenta / gold ovals before rim+specular). All params default to identity/off — zero existing call sites break.OGFireflySpecgainsscrollVX/scrollVY: Float = 0f(serializable).OGFireflyState.update()adds these to each firefly's normalised position per frame on top of Brownian drift;frac()gives toroidal wrap. UsescrollVX = -gameSpeed * 0.001fto drive the mote field with a game scroller.Fable review
Reviewed by
claude-fable-5. Two warnings fixed before merge:iriAlphaclamped to[0,1](ComposeColor.copy(alpha)throws outside range)r <= 0f(guardsradialGradientradius > 0 invariant)Test plan
OGBubbleFireflyExtTest(7 tests): scroll-velocity defaults, sanitize survival, codec round-trip, position shift correctness, toroidal wrap🤖 Generated with Claude Code