Skip to content

integrating auth mechanism in client - #4

Open
SiJu-SF wants to merge 3 commits into
developfrom
develop-auth
Open

integrating auth mechanism in client#4
SiJu-SF wants to merge 3 commits into
developfrom
develop-auth

Conversation

@SiJu-SF

@SiJu-SF SiJu-SF commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@SiJu-SF
SiJu-SF requested a review from kzoltner September 1, 2026 08:54
@SiJu-SF SiJu-SF self-assigned this Sep 1, 2026
@SiJu-SF SiJu-SF added the enhancement New feature or request label Sep 1, 2026
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 1, 2026

Copy link
Copy Markdown

Deploying shellsmith with  Cloudflare Pages  Cloudflare Pages

Latest commit: 99eda70
Status: ✅  Deploy successful!
Preview URL: https://849a6e2d.shellsmith.pages.dev
Branch Preview URL: https://develop-auth.shellsmith.pages.dev

View logs

@kzoltner
kzoltner requested a review from caha03 September 1, 2026 11:31
@kzoltner

kzoltner commented Sep 1, 2026

Copy link
Copy Markdown
Member

I would consider adding a test and environment for basyx + auth and basyx + non-auth.
I added CaHa since I don't think I can review the python code itself well enough.

@codecov

codecov Bot commented Sep 1, 2026

Copy link
Copy Markdown

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment

Thanks for integrating Codecov - We've got you covered ☂️

@caha03 caha03 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SiJu already included my feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants