Repository navigation
brreg_registre, udi: cite the 2025 register acts and link each UDI notice - #171
Merged
Merged
Conversation
…by URL brreg_registre rested on enhetsregisterloven 1994 (LOV-1994-06-03-15) and foretaksregisterloven 1985 (LOV-1985-06-21-78). Both were repealed from 2026-01-01 by LOV-2025-06-20-105 and LOV-2025-06-20-106. - Scenario 3 cites enhetsregisterloven 2025 §§ 1-4 and 3-1; the rule is unchanged, the register is now named Arbeidsgiver- og arbeidstakerregisteret. - Scenario 4 cites foretaksregisterloven 2025 §§ 2-1 and 2-2. The new § 2-2 no longer says a registered sole proprietorship is subject to the registration rules, so the item that required it is dropped. - Scenario 5 cites aksjeloven § 2-18 and foretaksregisterloven 2025 §§ 4-1 and 4-2. The new act has no separate six-month deadline for other limited-liability companies, so the item no longer calls that answer correct. The deadline fact now cites aksjeloven § 2-18. - The four statutory facts are re-verified on 2026-11-20 with review_by 2027-11-20. The rettsgebyr keeps 1 345 kroner and review_by 2027-01-01: the 2027 figure is only proposed. udi: replace the dead https://www.udi.no/viktige-meldinger/ with the URL of each of the three notices the pack quotes.
Collaborator
|
great contribution! Thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two source fixes in packs I wrote.
1. brreg_registre: the two register acts it cited were repealed on 1 January 2026
Scenarios 3, 4 and 5 cited enhetsregisterloven 1994 (LOV-1994-06-03-15) and foretaksregisterloven 1985 (LOV-1985-06-21-78). Both were repealed with effect from 2026-01-01 by the new enhetsregisterloven (LOV-2025-06-20-105) and foretaksregisterloven (LOV-2025-06-20-106). Lovdata now serves the old acts under
/dokument/NLO/with the banner «Opphevet», and the pack had described the 2025 acts as amendments. The scenarios now cite the 2025 acts. Every excerpt insource_quoteand infactswas re-matched verbatim against text fetched from Lovdata on 2026-11-20 (45 of 45).Per scenario:
Scenarios 1, 2, 6 and 7 are unchanged. Every quote from aksjeloven §§ 3-1, 7-6, 16-15 and 16-16, regnskapsloven §§ 8-2 and 8-3, FOR-2006-09-07-1062 § 8-3-1, rettsgebyrforskriften § 2-1 and FOR-2018-01-03-7 still matches the current text.
Facts.
stale_facts(SCENARIO_PACKS, "2027-01-02")returned five brreg facts.verified_at2026-11-20 andreview_by2027-11-20. No amendment that has been passed but is not yet in force touches their provisions. Lov 19. juni 2026 nr. 48, in force 2027-01-01, amends aksjeloven §§ 16-14, 16-17 and 16-19, not §§ 16-15 or 16-16.review_by2027-01-01. Prop. 1 S (2026–2027) for the Ministry of Justice proposes 1 380 kroner from 2027-01-01, but rettsgebyrforskriften § 2-1 has not yet been amended for 2027.Design question: the
stale_factsdocstring saysreview_by«is None for a figure fixed in statute». This pack instead re-reads its statutory figures once a year, which is how the repeal came to light. If you'd rather have None for those four, it is a one-line change.2. udi: the link to the notices returned 404
udi.pyandudi_README.mdpointed tohttps://www.udi.no/viktige-meldinger/, which returns 404. Each of the three notices the pack quotes now has its own URL. Each returns 200 without a redirect, shows the publication date the pack gives (13.01.2025, 26.03.2024, 30.06.2025), and contains every sentence the pack quotes from it.Checked
scripts/check_scenario_pack.py brreg_registreandudi: exit 0, no errors or warnings.dev,tracing,plot,inspect,openenvas in CI): 2674 passed, 2 skipped.ruff check --select E9,F821: clean./..., no…in a URL, no TODO and no FIXME.No audit runs were repeated: the change is to sources and to two expectation items.
AI disclosure: implemented with Claude Code.