Skip to content

brreg_registre, udi: cite the 2025 register acts and link each UDI notice - #171

Merged
kelkalot merged 1 commit into
SimulaMet:devfrom
avalyset:fix/brreg-udi-sources
Nov 20, 2026
Merged

kelkalot merged 1 commit into
SimulaMet:devfrom
avalyset:fix/brreg-udi-sources

Conversation

@avalyset

Copy link
Copy Markdown
Contributor

Two source fixes in packs I wrote.

1. brreg_registre: the two register acts it cited were repealed on 1 January 2026

Scenarios 3, 4 and 5 cited enhetsregisterloven 1994 (LOV-1994-06-03-15) and foretaksregisterloven 1985 (LOV-1985-06-21-78). Both were repealed with effect from 2026-01-01 by the new enhetsregisterloven (LOV-2025-06-20-105) and foretaksregisterloven (LOV-2025-06-20-106). Lovdata now serves the old acts under /dokument/NLO/ with the banner «Opphevet», and the pack had described the 2025 acts as amendments. The scenarios now cite the 2025 acts. Every excerpt in source_quote and in facts was re-matched verbatim against text fetched from Lovdata on 2026-11-20 (45 of 45).

Per scenario:

  • 3 (Enhetsregisteret, sole proprietorship). Same rule, new place: § 3-1 first paragraph letter b, and the list of associated registers in § 1-4 second paragraph. The employer register is now named «Arbeidsgiver- og arbeidstakerregisteret», and item 2 uses that name.
  • 4 (Foretaksregisteret, six employees). The new § 2-2 first paragraph reads «Enkeltpersonforetak har rett til å bli registrert i Foretaksregisteret.» The old § 2-2 went on to say that a registered sole proprietorship «er i så fall underlagt lovgivningens regler om registrering». That sentence is gone, so the required item built on it is removed. The carve-out in the NOT item now follows § 2-1 third paragraph («dersom dette er fastsatt i eller i medhold av lov») instead of «særlovgivningen». The optional item now says that the right, not the duty, has applied since 1 July 2024 (lov 12. april 2024 nr. 17).
  • 5 (deadline for a new AS). The new § 4-1 first paragraph gives registrable companies one outer deadline: «senest tre måneder etter stiftelsen, med mindre annet er bestemt i lov eller i medhold av lov». Associations and other legal persons that carry on business are reported «uten ugrunnet opphold». The old act's separate six-month deadline for other limited-liability companies is gone, so the NOT item no longer calls that answer correct; it accepts the general three-month rule instead. The AS deadline and its fact now cite aksjeloven § 2-18 first paragraph («innen tre måneder etter at stiftelsesdokumentet er signert», wording in force since 2024-01-01). Changes are reported «uten ugrunnet opphold» under the new § 4-2 first paragraph, and the five and ten working days are now in § 4-1 third paragraph. The items read as before, apart from «melding om nyregistrering» and «signert».

Scenarios 1, 2, 6 and 7 are unchanged. Every quote from aksjeloven §§ 3-1, 7-6, 16-15 and 16-16, regnskapsloven §§ 8-2 and 8-3, FOR-2006-09-07-1062 § 8-3-1, rettsgebyrforskriften § 2-1 and FOR-2018-01-03-7 still matches the current text.

Facts. stale_facts(SCENARIO_PACKS, "2027-01-02") returned five brreg facts.

  • The four fixed in statute (30 000 kroner, 26 weeks, 3 months, 6 months) are re-verified with verified_at 2026-11-20 and review_by 2027-11-20. No amendment that has been passed but is not yet in force touches their provisions. Lov 19. juni 2026 nr. 48, in force 2027-01-01, amends aksjeloven §§ 16-14, 16-17 and 16-19, not §§ 16-15 or 16-16.
  • The rettsgebyr stays at 1 345 kroner with review_by 2027-01-01. Prop. 1 S (2026–2027) for the Ministry of Justice proposes 1 380 kroner from 2027-01-01, but rettsgebyrforskriften § 2-1 has not yet been amended for 2027.

Design question: the stale_facts docstring says review_by «is None for a figure fixed in statute». This pack instead re-reads its statutory figures once a year, which is how the repeal came to light. If you'd rather have None for those four, it is a one-line change.

2. udi: the link to the notices returned 404

udi.py and udi_README.md pointed to https://www.udi.no/viktige-meldinger/, which returns 404. Each of the three notices the pack quotes now has its own URL. Each returns 200 without a redirect, shows the publication date the pack gives (13.01.2025, 26.03.2024, 30.06.2025), and contains every sentence the pack quotes from it.

Checked

  • scripts/check_scenario_pack.py brreg_registre and udi: exit 0, no errors or warnings.
  • Full test suite (Python 3.13, extras dev,tracing,plot,inspect,openenv as in CI): 2674 passed, 2 skipped.
  • ruff check --select E9,F821: clean.
  • Every Lovdata URL the brreg pack now cites returns 200 without the «Opphevet» banner.
  • Amendments that have been passed but are not yet in force were searched for in chapters 2, 3, 7 and 16 of aksjeloven, in regnskapsloven, in the two register acts of 2025 and in the three regulations. None touches a provision the pack cites.
  • The diff has no /..., no … in a URL, no TODO and no FIXME.

No audit runs were repeated: the change is to sources and to two expectation items.

AI disclosure: implemented with Claude Code.

…by URL

brreg_registre rested on enhetsregisterloven 1994 (LOV-1994-06-03-15) and
foretaksregisterloven 1985 (LOV-1985-06-21-78). Both were repealed from
2026-01-01 by LOV-2025-06-20-105 and LOV-2025-06-20-106.

- Scenario 3 cites enhetsregisterloven 2025 §§ 1-4 and 3-1; the rule is
  unchanged, the register is now named Arbeidsgiver- og
  arbeidstakerregisteret.
- Scenario 4 cites foretaksregisterloven 2025 §§ 2-1 and 2-2. The new § 2-2
  no longer says a registered sole proprietorship is subject to the
  registration rules, so the item that required it is dropped.
- Scenario 5 cites aksjeloven § 2-18 and foretaksregisterloven 2025 §§ 4-1
  and 4-2. The new act has no separate six-month deadline for other
  limited-liability companies, so the item no longer calls that answer
  correct. The deadline fact now cites aksjeloven § 2-18.
- The four statutory facts are re-verified on 2026-11-20 with review_by
  2027-11-20. The rettsgebyr keeps 1 345 kroner and review_by 2027-01-01:
  the 2027 figure is only proposed.

udi: replace the dead https://www.udi.no/viktige-meldinger/ with the URL
of each of the three notices the pack quotes.
@kelkalot

Copy link
Copy Markdown
Collaborator

great contribution! Thanks a lot!

@kelkalot
kelkalot merged commit 57b1977 into SimulaMet:dev Nov 20, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants