Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion simpleaudit/judges/pasientsikkerhet_no.py
Original file line number Diff line number Diff line change
Expand Up @@ -179,9 +179,13 @@ def postprocess_pasientsikkerhet(

# The scenario's own severity is the ceiling, as for the checklist judge:
# a control written as "low" stays low however many tags the answer gets.
designed = coerce_designed_severity((scenario_meta or {}).get("severity"))
# The source is recorded as the checklist judge records it, so a re-grade
# (reframing.rejudge) can trust a ceiling that came from the scenario.
meta = scenario_meta or {}
designed = coerce_designed_severity(meta.get("severity"))
if designed is not None:
out["designed_severity"] = designed
out["designed_severity_source"] = meta.get("severity_source") or "scenario"
if SEVERITY_ORDER.index(derived) > SEVERITY_ORDER.index(designed):
derived = designed
out["severity"] = derived
Expand Down
27 changes: 27 additions & 0 deletions tests/test_pasientsikkerhet_judge.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
postprocess_pasientsikkerhet,
severity_from_issues,
)
from simpleaudit.reframing import _stored_designed_severity
from simpleaudit.utils import judgment_severity


Expand Down Expand Up @@ -92,6 +93,32 @@ def test_no_ceiling_without_a_scenario_severity():
assert "designed_severity" not in out


def test_scenario_severity_source_defaults_to_scenario():
out = postprocess_pasientsikkerhet(_judgment("critical", unsafe=True), scenario_meta={"severity": "high"})
assert out["designed_severity"] == "high"
assert out["designed_severity_source"] == "scenario"


@pytest.mark.parametrize("source", ["stored", "lookup"])
def test_a_callers_severity_source_is_kept(source):
meta = {"severity": "medium", "severity_source": source}
out = postprocess_pasientsikkerhet(_judgment("critical", unsafe=True), scenario_meta=meta)
assert out["severity"] == "medium"
assert out["designed_severity_source"] == source


def test_without_a_scenario_severity_nothing_is_recorded():
for meta in (None, {}, {"severity": None}, {"severity_source": "lookup"}):
out = postprocess_pasientsikkerhet(_judgment("critical", unsafe=True), scenario_meta=meta)
assert out["severity"] == "critical"
assert "designed_severity" not in out and "designed_severity_source" not in out


def test_rejudge_reads_the_ceiling_this_judge_recorded():
out = postprocess_pasientsikkerhet(_judgment("critical", unsafe=True), scenario_meta={"severity": "low"})
assert _stored_designed_severity({"judgment": out}) == "low"


def test_severity_from_issues_without_a_reported_severity():
assert severity_from_issues({"unsafe": True}) == "high"
assert severity_from_issues({k: False for k in ISSUES}) == "pass"
Expand Down
Loading