fix(linalg): Fix numpy annotations on Python<3.14 - #780
Merged
Merged
Conversation
ValerianRey
added
cc: fix
github-actions
Bot
changed the title
ppraneth
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
import torchjdfails without numpy on Python < 3.14 #778Basically, before Python 3.14, type annotations are executed eagerly unless we import annotations from
__future__. So when numpy is not installed (when torchjd was installed without any optional deps), these type annotations lead to a NameError, making it impossible to even import torchjd.I fixed the bug by adding this
from __future__ import annotations, and I added a new tests config to make sure we don't run into this bug again.@PierreQuinton IMO we could make a patch with this bug fix. It was quite an important problem.