Repository navigation
fix(table): make hash traversal linear - #152
Open
efegokdemir wants to merge 3 commits into
Open
efegokdemir wants to merge 3 commits into
efegokdemir wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hash-backed
nexttraversals rescan the cached key list on every call. Cache each key's position so a complete traversal is linear, using raw key identity rather than invoking__eqfor table or userdata keys. The index is built lazily and invalidated when a new hash key is inserted.A local
Nextmicrobenchmark with 50,000 string keys went from 33.27 s to 8.29 ms (median of three first traversals, Go 1.27.1, Apple M2). First-traversal allocations increased from 0.80 MB to 2.55 MB for the position index.Focused race tests passed in 20 runs, as did builds with Go 1.22.1 and 1.27.1 and production-code vet. The full race suite fails
TestParserExhaustivelyon a1e33rounding difference with Lua 5.2.4; full vet reports the existingExampleFunctionsignature errors indoc_test.go. Both also reproduce with upstreamtables.go.Fixes #136.