Repository navigation
Closed-loop product hardening: audit replay and package verification - #34
Shards-inc wants to merge 12 commits into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 565ff6ad0f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .tmp/wheel-smoke/bin/python -m pip install --no-deps dist/*.whl | ||
| cd /tmp | ||
| "$GITHUB_WORKSPACE/.tmp/wheel-smoke/bin/python" - <<'PY' | ||
| import implementations |
There was a problem hiding this comment.
Package the reference implementations in the wheel
pyproject.toml limits setuptools package discovery to include = ["kernels*"], so adding this __init__.py does not include the top-level implementations package in the wheel. The new /tmp smoke import therefore raises ModuleNotFoundError in every CI matrix job, and installed users cannot import either reference implementation; include implementations* in package discovery or move these modules under kernels.
Useful? React with 👍 / 👎.
Diagnostic findings
This branch addresses two concrete product-level defects found during the closed-loop review:
AuditLedger.append()commits permit metadata into the hash preimage, whilereplay_and_verify()previously omitted those fields. A valid permit-bearing ledger therefore could not be independently replay-verified.implementations.*, butimplementations/had no__init__.py. The package build configuration discovers Python packages, so the reference implementations were not guaranteed to ship in built distributions.Changes
implementations/__init__.pyso reference implementations are packaged explicitly.kernelsand shippedimplementationsmodules.Verification
GitHub Actions is the authoritative execution environment for the full matrix. The branch is intentionally not merged automatically; merge remains a human-controlled release decision.