Repository navigation
feat(update): add a nightly update channel signed by its own key - #87
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Adds a 每日构建 update channel so people who want the newest build get it every morning without reinstalling, as the maintainer asked. Until now nightlies were download-only. Design and trade-offs: ADR-0014 (proposed), which amends ADR-0010.
NIGHTLY_UPDATE_KEYSis trusted forupdate-nightly.jsononly (trustedUpdateKeys(channel)). The key lives in a newnightlyenvironment without a reviewer. The production key and thereleaseenvironment are untouched.-nightly.versions.minimumVersionand a nightly waiting to install. The running version stays until a steadier channel has a newer one (no downgrade).install.jsonkeepsstable/beta(RECORD_CHANNELS), because installed launchers accept nothing else and are never updated.updateChannel: 'beta'+nightlyUpdates, and the flag counts only withbeta, so rolling back to an older version reads it as 测试版 and keeps updating.nightly.yml):X.Y.Z-nightly.YYYYMMDD.<run>.MOSS_NIGHTLY_SIGNING_KEYset, the run fetches the last nightly (fetch-nightly.mjs), builds deltas from it, writes and signsupdate-nightly.json(make-feed.mjs --nightly) and verifies it againstNIGHTLY_UPDATE_KEYS.updatesrelease, then the.sig, then the feed, and only then prunes nightlies older than the previous one.How it was verified
pnpm lint: 0 errors, the same 12 warnings as main.pnpm format:checkandpnpm typecheckare clean.pnpm test:unit: 3560 passed.pnpm test:e2e: 345 passed.update.e2e.tsnow picks 每日构建 and saves the screenshotupdate-channel-nightly-light; the visual suite covers 设置 › 更新 in light and dark.pnpm test:install: PASS (Linux: install 2.0.0, update to 2.0.1, roll back from 2.0.2, uninstall).docs/how-to/release.md(nightly section, nightly key setup and rotation),docs/reference/architecture.md, ADR-0014 with the index and ADR-0010'samended-by, anddocs/README.md.nightlyUpdates;make-feed --nightlyend to end, and prune selection.Platforms affected
Notes for the reviewer
NIGHTLY_UPDATE_KEYSis empty, so nothing changes in practice until a maintainer runspnpm release:keygen --nightly, merges the public key and addsMOSS_NIGHTLY_SIGNING_KEYto anightlyenvironment limited tomain(see the release how-to).PRODUCTION_UPDATE_KEYSis still empty too, so no released build can update yet, on any channel.