Repository navigation
Clarify that a rejected unapproved client is still presented - #308
Open
arturpragacz wants to merge 1 commit into
Open
arturpragacz wants to merge 1 commit into
arturpragacz wants to merge 1 commit into
Conversation
Contributor
|
Going back to this now, I can see that basically all my questions/issues in #296 were addressed in some form in the spec, I just missed it. So, I'm fine with actually leaving it as is without this clarification. I think the issue was just how aiosendspin/MA handled it; e.g., it wouldn't let you try to connect to a client to pair when it previously got the concurrent attempt rejection. |
kahrendt
approved these changes
Oct 14, 2026
kahrendt
left a comment
kahrendt
left a comment
Contributor
There was a problem hiding this comment.
The change is good, but may not be necessary. So, if you want the clarification in go ahead and merge!
1 of 9 tasks
maximmaxim345
added a commit
to Sendspin/aiosendspin
that referenced
this pull request
Oct 15, 2026
# What does this implement/fix? <!-- Quick description and explanation of changes. --> With two servers, a device held by one server turned the other one away with `concurrent_attempt`. The other server then redialed it on every mDNS update and forgot it after three minutes, so its player went unavailable and then disappeared. The server now keeps such a client like after `another_server`: it fires `ClientAddedEvent` for it, stops its playback on this server, and only dials it again on a reclaim or when its mDNS record goes away and comes back. **Related issue or spec PR (if applicable):** - Sendspin/spec#308 ## Types of changes <!-- Tick exactly one box. CI (.github/workflows/pr-labels.yaml) applies the matching label, and the release notes use it to sort this change. --> - [x] Bugfix (non-breaking change which fixes an issue): `bugfix` - [ ] New feature (non-breaking change which adds functionality): `new-feature` - [ ] Enhancement to an existing feature: `enhancement` - [ ] Breaking change (changes the public API or the protocol in a way that is not backwards compatible): `breaking-change` - [ ] Refactor (no behavior change): `refactor` - [ ] Documentation only: `documentation` - [ ] Maintenance / chore: `maintenance` - [ ] CI / workflow change: `ci` - [ ] Dependencies bump: `dependencies`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarify that a rejected unapproved client is still presented.
This was already the intended reading of the spec, but let's make it completely clear.
Closes #296.