Repository navigation
Allow a gap at player format changes - #301
Open
maximmaxim345 wants to merge 2 commits into
Open
maximmaxim345 wants to merge 2 commits into
maximmaxim345 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Servers that share one encoder between players can only switch a player's format at that encoder's next chunk boundary, so they couldn't meet the exact timestamp rule. The server should still continue exactly where the previous format ends, but may now leave a gap. Overlaps and resent audio stay forbidden, and players already fill the gap with silence through the existing sync rules.
Switching the output between formats without adding a gap is now the player's job. Players that can't do that should keep listing a single sample rate and channel count, as before.
aiosendspin already follows these rules since:
Closes #294