Repository navigation
Clarify an ambiguity in Client Initiated Connections - #290
Merged
Merged
Conversation
From the wording of the spec, it's unclear whether the intention was that mDNS was the only method that clients could use to discover a server, or if they were permitted to connect to servers that they had discovered in some other way (e.g. a manually entered `ws://` url). I think that permitting other methods of discovering the server is fine, so I've added the BCP-14 keyword "SHOULD" to the statement to make that clear; see https://www.rfc-editor.org/info/rfc2119/#section-3 for the exact meaning of this keyword.
kepstin
force-pushed
the
client-connection
branch
from
September 17, 2026 20:33
241fe87 to
1412015
Compare
Contributor
Author
|
As an additional note, Javascript running in web browsers is unable to either accept incoming connections or perform mDNS service discovery, so all connections made by JS sendspin clients will be client-initiated connections to a websocket URL provided via an out-of-band mechanism. |
maximmaxim345
approved these changes
Oct 8, 2026
maximmaxim345
left a comment
maximmaxim345
left a comment
Member
There was a problem hiding this comment.
Thanks @kepstin, good catch!
Only pushed a small fix on top so the SHOULD doesn't also cover using the advertised address and path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the wording of the spec, it's unclear whether the intention was that mDNS was the only method that clients could use to discover a server, or if they were permitted to connect to servers that they had discovered in some other way (e.g. a manually entered
ws://url).I think that permitting other methods of discovering the server is fine in some circumstances, so I've added the BCP-14 keyword SHOULD to the statement to make that clear.
If the intent was that mDNS is the only method that clients are permitted to use to discover the server, then I'd recommend using the MUST keyword instead.