Repository navigation
Conversation
The Reset Link Sent card was a dead end. Reuse the reset-success Log In button there, via one shared constant, and add AuthPage tests for the forgot, expired, valid-link, success and no-account screens. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WUGV6KW3Gv4JhQuYWD3LMa
Pin the reset-confirm form validation, request bodies, invalid-link hand-off, field and banner errors, and the expired view's resend and no-account branches. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WUGV6KW3Gv4JhQuYWD3LMa
…(sc-44747) Add UMN-A09 to A12 to auth-page.spec.ts: the Log In button on Reset Link Sent, the expired-link page and resend, the no-account banner, and a Hebrew smoke test. They intercept only the confirm-URL POST and use a uid no account owns. Not executed: no local Sefaria stack. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WUGV6KW3Gv4JhQuYWD3LMa
…ounted state update (sc-44747) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WUGV6KW3Gv4JhQuYWD3LMa
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Finishes the forgot/reset-password screen refresh. The "Reset link sent" state now has a way back to log in, two navigation and state bugs in the reset flow are fixed, and the reset screens get test coverage.
Shortcut Story: SC-44747
Changes
AuthPage.jsx: "Reset link sent" state gets a Log In button (existingauth.log_in_linkstring, no new i18n key).AuthPage.jsx: the no-account banner's "Request new link" now lands on the Forgot Password view. It used to fall back to Log In; the comment aboverequestNewLinkalready described the intended behaviour.ResetExpiredView.jsx:handleResendreturns afteronResendSuccess(), so it no longer sets state on an unmounted component.ResetView.test.js,ResetExpiredView.test.js, plus additions toAuthPage.test.js.e2e-tests/full-testing-by-feature/User Menu/auth-page.spec.ts(the Reset Link Sent button, the banner link, the reset-confirm and expired views).Testing
npx jest static/js/auth: 11 suites, 129 tests passpython manage.py runserverNotes
🤖 Generated with Claude Code
https://claude.ai/code/session_01WUGV6KW3Gv4JhQuYWD3LMa