Repository navigation
Reader spec: daily changes 2026-10-19 - #3826
Draft
claude[bot] wants to merge 1 commit into
Draft
claude[bot] wants to merge 1 commit into
claude[bot] wants to merge 1 commit into
Conversation
…s as ideas i18n-a11y and versions: legacy rules (master @ 121350b) vs reader-next (@ 837d585) with file:line, gaps, legacy behaviour not to port, and open questions, all marked idea. CROSS_CUTTING lists atlas marks the code does not fully back (RTE-028, RTE-034, SHL-007, VER-014, VER-012, SHL-014). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YVk1KuVVM9g2qUYR976dBm
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Akiva Berger · Slack thread
Before: the spec had no rules for interface language, content language or version stickiness. Every channel section of
i18n-a11yandversionswas "Not discussed yet.", and the only source was the Feature Atlas, which marks several of these items done although the code does not fully back them.After:
i18n-a11yandversionsmap the legacy rules (master@ 121350b: interface precedence profile → cookie → country → browser language → English, domain pinning andset-language-cookie, bots, non-Torah sites, the three writers; content languagelang/lang<n>→contentLangcookie → Hebrew for a Hebrew interface, else bilingual; version URL params and their correction, client resolution order, profile-first vs cookie-only preferences, the location-based suggestion banner). They also cover whatreader-next@ 837d585 ports, its gaps (including two likely bugs: avhe-only URL loses the preference atTextPanel.tsx:84, and an unknown explicitvenshows no translation instead of the default), legacy behaviour not to port, and open questions. Everything is marked idea; nothing was added toDECISIONS.md. Both areas movebaseline→exploring.How: filled the Summary, Legacy vs new, Dependencies and Risks/Open questions sections (plus Changes from today and Open questions in the product docs), and added a "Legacy behaviour not to port" section, in
docs/reader-future/i18n-a11y/{product,architecture}.mdanddocs/reader-future/versions/{product,architecture}.md. FilledCROSS_CUTTING.md→ "Accessibility and languages" with pointers and a list of atlas marks the code does not fully back (RTE-028, RTE-034, SHL-007, VER-014; VER-012's note is stale; SHL-014 is done but the reader-shell baseline says not started). The atlas and BASELINE blocks are unchanged. Code links are pinned to SHAs. The open questions point to the settings registry proposed in PR #3822 by name.Generated by Claude Code